You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2023/11/03 06:24:45 UTC

[PR] support non-constant expressions for path arguments for json_value and json_query (druid)

clintropolis opened a new pull request, #15320:
URL: https://github.com/apache/druid/pull/15320

   ### Description
   This PR adds support for using expressions to compute the json path argument for `JSON_VALUE` and `JSON_QUERY` functions. Note that when using a path expression that isn't a constant, Druid cannot take advantage of the specialized virtual column typically used, and so must fall back to a pure expression virtual column to compute the values from the 'raw' json blob, which will be much less performant than if the path is constant and known up front.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] support non-constant expressions for path arguments for json_value and json_query (druid)

Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #15320:
URL: https://github.com/apache/druid/pull/15320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org