You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/09/09 02:20:33 UTC

[GitHub] [druid] kfaraz opened a new pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

kfaraz opened a new pull request #11680:
URL: https://github.com/apache/druid/pull/11680


   Fixes #XXXX.
   
   ### Description
   Users with DATASOURCE READ access can currently call GET and HEAD APIs
   on Supervisor and Task resources. These resources respond with ingestion related
   information, which should be visible only to DATASOURCE WRITE users.
   
   ### Changes
   - Always require DATASOURCE WRITE access in `SupervisorResourceFilter` and `TaskResourceFilter`
   
   <hr>
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-918136209


   Thanks for checking, @clintropolis . I am taking another pass at the APIs and will share the results of my findings here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-925320021


   Removed milestone `0.22.0` since the backport PR was not merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-916209027


   @kfaraz Is it possible to add integration tests that call all the different endpoints that are available on the ingest path and validate that a user needs DATASOURCE WRITE permission to see .
   
   I skimmed the code and noticed users with DATASOURCE READ can see metadata about the segments. I think this seems ok since a DATASOURCE READ user may need to know which segments were available when a query was executed so they would have a need. 
   
   I dug a little bit and it seems like the segment metadata could include the loadSpec. Do you think that should also require DATASOURCE WRITE permissions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-916278476


   Thanks for the review, @suneet-s . I will add an integration test in a follow up PR (hopefully within a couple of days). I will also spend some time on the access of segment metadata and propose required changes, if any.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis merged pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11680:
URL: https://github.com/apache/druid/pull/11680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-917918247


   I missed a couple of things in my initial review, SQL queries to sys.tasks and sys.supervisors still use read permissions and a handful of task report APIs also still use read instead of write
   
   
   ![Screen Shot 2021-09-09 at 1 53 58 PM](https://user-images.githubusercontent.com/1577461/133041439-c33ec9b2-bf3b-49f2-a4fa-beb2c356b1d6.png)
   ![Screen Shot 2021-09-09 at 1 54 08 PM](https://user-images.githubusercontent.com/1577461/133041468-7e8d7ced-775a-4fe7-86d2-cc587bb9c4cf.png)
   
   so this change isn't quite yet complete I think. (I do still think WRITE makes more sense for the changes here and all of these APIs). I'm not sure if I missed any others, probably worth having another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org