[GitHub] [iceberg] rdblue commented on a diff in pull request #4703: API: Optionally ignore position deletes in rewrite validation

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4703:
URL: https://github.com/apache/iceberg/pull/4703#discussion_r868755289


##########
api/src/main/java/org/apache/iceberg/RewriteFiles.java:
##########
@@ -84,4 +84,16 @@ RewriteFiles rewriteFiles(Set<DataFile> dataFilesToReplace, Set<DeleteFile> dele
    * @return this for method chaining
    */
   RewriteFiles validateFromSnapshot(long snapshotId);
+
+  /**
+   * Set the snapshot ID used in any reads for this operation.
+   * <p>
+   * Validations will check changes after this snapshot ID. If this is not called, all ancestor snapshots through the
+   * table's initial snapshot are validated.
+   *
+   * @param snapshotId a snapshot ID
+   * @param ignorePosDeletes whether to ignore position delete in validation
+   * @return this for method chaining
+   */
+  RewriteFiles validateFromSnapshot(long snapshotId, boolean ignorePosDeletes);

Review Comment:
   I don't think this is the right way to configure this option. Why not add a new method since this is orthogonal to the snapshot you're validating from? Or is there a more appropriate `validate` method that could be updated instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org