[GitHub] [incubator-dlab] ofuks commented on a change in pull request #542: [DLAB-1447] Verification of the enpoint url field

[GitBox <gi...@apache.org>]

ofuks commented on a change in pull request #542: [DLAB-1447] Verification of the enpoint url field
URL: https://github.com/apache/incubator-dlab/pull/542#discussion_r370366522
 
 

 ##########
 File path: services/self-service/src/main/java/com/epam/dlab/backendapi/dao/EndpointDAO.java
 ##########
 @@ -23,15 +23,33 @@
 
 import java.util.List;
 import java.util.Optional;
+import java.util.regex.Pattern;
 
+/**
+ * Interface of Endpoint entities.
+ */
 public interface EndpointDAO {
 	List<EndpointDTO> getEndpoints();
 
 	List<EndpointDTO> getEndpointsWithStatus(String status);
 
+	/***
+	 * @param name - The Pattern interface is used, to avoid case sensitive Name
+	 * @return
+	 */
+	Optional<EndpointDTO> get(Pattern name);
+
+	/***
+	 * @param name - case sensitive EnaPoint Name
+	 * @return
+	 */
 	Optional<EndpointDTO> get(String name);
 
-	Optional<EndpointDTO> getEndpointWithUrl(String url);
+	/***
+	 * @param url - The Pattern interface is used, to avoid case sensitive URL
+	 * @return
 
 Review comment:
   the same

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org