You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Daniel Klco <dk...@apache.org> on 2021/01/15 17:39:35 UTC
[VOTE] Release Apache Sling Rewriter 1.3.0
Hi,
We solved 9 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12342644
I bumped to 1.3 due to the HTM5 serializer support which is backwards
compatible.
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2399/
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2399 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
[RESULT] [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Daniel Klco <dk...@apache.org>.
Hi,
The vote has passed with the following result :
+1 (binding): Nicolas Peltier, Stefan Seifert, Dan Klco
+1 (non binding): N/A
I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.
RE: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
+1
Re: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Nicolas Peltier <pe...@gmail.com>.
+1
Le ven. 15 janv. 2021 à 18:39, Daniel Klco <dk...@apache.org> a écrit :
> Hi,
>
> We solved 9 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12342644
>
> I bumped to 1.3 due to the HTM5 serializer support which is backwards
> compatible.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2399/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2399 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
Re: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Daniel Klco <da...@gmail.com>.
Stefan,
I verified by reproducing and fixing the test on Windows 10. The issue is
the test expects a line ending of \n when checking the output from printing
the doctype. Changing the test resolved the issue and otherwise there seem
to be no issues with the implementation code. I will fix the test to work
for \r\n and \n line endings after this release.
In the meantime, here's my:
+1
On Mon, Jan 18, 2021 at 2:21 AM Stefan Seifert
<St...@diva-e.com.invalid> wrote:
> hallo daniel.
>
> it's likely only a problem in the unit tests, but maybe also a problem in
> the production code itself? in the first case it would be fine for me to
> continue with the release, in the latter we should cancel it.
>
> stefan
>
>
> >-----Original Message-----
> >From: Daniel Klco <da...@gmail.com>
> >Sent: Saturday, January 16, 2021 6:14 PM
> >To: dev@sling.apache.org
> >Subject: Re: [VOTE] Release Apache Sling Rewriter 1.3.0
> >
> >Thanks for the note and catch Stefan. Are you a -1 or okay with fixing the
> >test post-release?
> >
> >On Sat, Jan 16, 2021 at 2:43 AM Stefan Seifert
> ><St...@diva-e.com.invalid> wrote:
> >
> >> i've a problem running the unit test on windows - seems to be a line
> >> ending issue (see below).
> >> another cosmetic remark: please put the SLING ticket number in the git
> >> commit messages, otherwise it's difficult to associate it.
> >>
> >> stefan
> >>
> >>
> >>
> -------------------------------------------------------------------------
> >------
> >> Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
> >>
> >>
> -------------------------------------------------------------------------
> >------
> >> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s
> >> <<< FAILURE! - in
> >> org.apache.sling.rewriter.impl.components.Html5SerializerTest
> >>
>
> >org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
> >ment
> >> Time elapsed: 0.147 s <<< FAILURE!
> >> org.junit.ComparisonFailure:
> >> expected:<<!DOCTYPE html>[]
> >> > but was:<<!DOCTYPE html>[
> >> ]
> >> >
> >> at
> >>
>
> >org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
> >ment(Html5SerializerTest.java:113)
> >>
> >>
> >>
> >>
> >> >-----Original Message-----
> >> >From: Daniel Klco <dk...@apache.org>
> >> >Sent: Friday, January 15, 2021 6:40 PM
> >> >To: dev@sling.apache.org
> >> >Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
> >> >
> >> >Hi,
> >> >
> >> >We solved 9 issues in this release:
> >> >https://issues.apache.org/jira/projects/SLING/versions/12342644
> >> >
> >> >I bumped to 1.3 due to the HTM5 serializer support which is backwards
> >> >compatible.
> >> >
> >> >Staging repository:
> >> >
> https://repository.apache.org/content/repositories/orgapachesling-2399/
> >> >
> >> >You can use this UNIX script to download the release and verify the
> >> >signatures:
> >> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
> >> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >> >
> >> >Usage:
> >> >sh check_staged_release.sh 2399 /tmp/sling-staging
> >> >
> >> >Please vote to approve this release:
> >> >
> >> > [ ] +1 Approve the release
> >> > [ ] 0 Don't care
> >> > [ ] -1 Don't release, because ...
> >> >
> >> >This majority vote is open for at least 72 hours.
> >>
>
RE: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
hallo daniel.
it's likely only a problem in the unit tests, but maybe also a problem in the production code itself? in the first case it would be fine for me to continue with the release, in the latter we should cancel it.
stefan
>-----Original Message-----
>From: Daniel Klco <da...@gmail.com>
>Sent: Saturday, January 16, 2021 6:14 PM
>To: dev@sling.apache.org
>Subject: Re: [VOTE] Release Apache Sling Rewriter 1.3.0
>
>Thanks for the note and catch Stefan. Are you a -1 or okay with fixing the
>test post-release?
>
>On Sat, Jan 16, 2021 at 2:43 AM Stefan Seifert
><St...@diva-e.com.invalid> wrote:
>
>> i've a problem running the unit test on windows - seems to be a line
>> ending issue (see below).
>> another cosmetic remark: please put the SLING ticket number in the git
>> commit messages, otherwise it's difficult to associate it.
>>
>> stefan
>>
>>
>> -------------------------------------------------------------------------
>------
>> Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
>>
>> -------------------------------------------------------------------------
>------
>> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s
>> <<< FAILURE! - in
>> org.apache.sling.rewriter.impl.components.Html5SerializerTest
>>
>org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
>ment
>> Time elapsed: 0.147 s <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<<!DOCTYPE html>[]
>> > but was:<<!DOCTYPE html>[
>> ]
>> >
>> at
>>
>org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocu
>ment(Html5SerializerTest.java:113)
>>
>>
>>
>>
>> >-----Original Message-----
>> >From: Daniel Klco <dk...@apache.org>
>> >Sent: Friday, January 15, 2021 6:40 PM
>> >To: dev@sling.apache.org
>> >Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
>> >
>> >Hi,
>> >
>> >We solved 9 issues in this release:
>> >https://issues.apache.org/jira/projects/SLING/versions/12342644
>> >
>> >I bumped to 1.3 due to the HTM5 serializer support which is backwards
>> >compatible.
>> >
>> >Staging repository:
>> >https://repository.apache.org/content/repositories/orgapachesling-2399/
>> >
>> >You can use this UNIX script to download the release and verify the
>> >signatures:
>> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
>> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>> >
>> >Usage:
>> >sh check_staged_release.sh 2399 /tmp/sling-staging
>> >
>> >Please vote to approve this release:
>> >
>> > [ ] +1 Approve the release
>> > [ ] 0 Don't care
>> > [ ] -1 Don't release, because ...
>> >
>> >This majority vote is open for at least 72 hours.
>>
Re: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Daniel Klco <da...@gmail.com>.
Thanks for the note and catch Stefan. Are you a -1 or okay with fixing the
test post-release?
On Sat, Jan 16, 2021 at 2:43 AM Stefan Seifert
<St...@diva-e.com.invalid> wrote:
> i've a problem running the unit test on windows - seems to be a line
> ending issue (see below).
> another cosmetic remark: please put the SLING ticket number in the git
> commit messages, otherwise it's difficult to associate it.
>
> stefan
>
>
> -------------------------------------------------------------------------------
> Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
>
> -------------------------------------------------------------------------------
> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s
> <<< FAILURE! - in
> org.apache.sling.rewriter.impl.components.Html5SerializerTest
> org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument
> Time elapsed: 0.147 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<<!DOCTYPE html>[]
> > but was:<<!DOCTYPE html>[
> ]
> >
> at
> org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument(Html5SerializerTest.java:113)
>
>
>
>
> >-----Original Message-----
> >From: Daniel Klco <dk...@apache.org>
> >Sent: Friday, January 15, 2021 6:40 PM
> >To: dev@sling.apache.org
> >Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
> >
> >Hi,
> >
> >We solved 9 issues in this release:
> >https://issues.apache.org/jira/projects/SLING/versions/12342644
> >
> >I bumped to 1.3 due to the HTM5 serializer support which is backwards
> >compatible.
> >
> >Staging repository:
> >https://repository.apache.org/content/repositories/orgapachesling-2399/
> >
> >You can use this UNIX script to download the release and verify the
> >signatures:
> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> >Usage:
> >sh check_staged_release.sh 2399 /tmp/sling-staging
> >
> >Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] 0 Don't care
> > [ ] -1 Don't release, because ...
> >
> >This majority vote is open for at least 72 hours.
>
RE: [VOTE] Release Apache Sling Rewriter 1.3.0
Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
i've a problem running the unit test on windows - seems to be a line ending issue (see below).
another cosmetic remark: please put the SLING ticket number in the git commit messages, otherwise it's difficult to associate it.
stefan
-------------------------------------------------------------------------------
Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
-------------------------------------------------------------------------------
Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s <<< FAILURE! - in org.apache.sling.rewriter.impl.components.Html5SerializerTest
org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument Time elapsed: 0.147 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<<!DOCTYPE html>[]
> but was:<<!DOCTYPE html>[
]
>
at org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument(Html5SerializerTest.java:113)
>-----Original Message-----
>From: Daniel Klco <dk...@apache.org>
>Sent: Friday, January 15, 2021 6:40 PM
>To: dev@sling.apache.org
>Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
>
>Hi,
>
>We solved 9 issues in this release:
>https://issues.apache.org/jira/projects/SLING/versions/12342644
>
>I bumped to 1.3 due to the HTM5 serializer support which is backwards
>compatible.
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2399/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2399 /tmp/sling-staging
>
>Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.