You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/16 23:26:19 UTC
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5112
to review the following change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
java-client: clean up intermediate tables in TestKuduTable
Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 63 insertions(+), 43 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5112/1
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Patch Set 1:
> We pretty routinely create test tables and don't clean them up,
> this is something of a special case because of the one test that is
> matching against the number of created tables. Perhaps that one
> test should just take into account how many are created at the
> beginning and do it based off that.
Seems cleaner.
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Patch Set 1:
So what was the issue?
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Patch Set 1:
One of the test cases in the file is matching on the number of created tables. Some of the test cases were creating and not cleaning up tables, thus there was a race based on the order of the test cases.
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Patch Set 1:
Should we just have a "delete all tables" after test method then?
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Patch Set 1:
We pretty routinely create test tables and don't clean them up, this is something of a special case because of the one test that is matching against the number of created tables. Perhaps that one test should just take into account how many are created at the beginning and do it based off that.
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java-client: clean up intermediate tables in TestKuduTable
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.
Change subject: java-client: clean up intermediate tables in TestKuduTable
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1b2778616c4b03679cf9264b38684d5de78277bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins