[GitHub] [incubator-pekko-projection] pjfanning commented on a diff in pull request #77: scala 3 support

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #77:
URL: https://github.com/apache/incubator-pekko-projection/pull/77#discussion_r1313949377


##########
build.sbt:
##########
@@ -153,9 +153,6 @@ lazy val `durable-state` =
       name := "pekko-projection-durable-state")
     .dependsOn(core)
     .dependsOn(testkit % Test)
-    .settings(
-      // no previous artifact so must disable MiMa until this is released at least once.
-      mimaPreviousArtifacts := Set.empty)

Review Comment:
   This disables the mima check - we actually want mima checks on all modules. After 1.0.0 is released, I will set this up properly but this setting will not be added back - so that the mima check will work. I will set a project level setting for mimaPreviousArtifacts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org