[GitHub] storm pull request #2351: [STORM-2765] Disallow colons in blobstore key name

[Ethanlm <gi...@git.apache.org>]

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2351

    [STORM-2765] Disallow colons in blobstore key name

    We should disallow colons in blobstore key name.  HDFS prohibits the use of ":" in path name. 
    
    ![image](https://user-images.githubusercontent.com/14900612/30991627-6552b530-a46b-11e7-98dc-e261af791988.png)
    
    
    [ Related code is here](https://github.com/apache/hadoop/blob/branch-2.6.1/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java#L237)
    
    Secondly, the original code uses two different functions to validate key names in different places. We probably just want to use one to avoid confusion. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2765

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2351
    
----
commit ff0f1e7d464f8992f5f2f21859b2a925a03fdd7b
Author: Ethan Li <et...@gmail.com>
Date:   2017-09-28T18:46:14Z

    [STORM-2765] Disallow colons in blobstore key name

----


---

[GitHub] storm pull request #2351: [STORM-2765] Disallow colons in blobstore key name

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2351


---