[GitHub] [cordova-android] distinctdan commented on issue #733: Fixes nav and title bars flashing in fullscreen mode for splashscreen plugin

[GitBox <gi...@apache.org>]

distinctdan commented on issue #733: Fixes nav and title bars flashing in fullscreen mode for splashscreen plugin
URL: https://github.com/apache/cordova-android/pull/733#issuecomment-549191945
 
 
   Hmm, perhaps my language wasn't clear enough. I didn't mean to specify a literal flash, just that the status bar and nav controls would pop in while the splashscreen is visible. The correct behavior is that they should be completely hidden if the splashscreen specifies fullscreen mode. For example, here's a screenshot of my app's splashscreen running on the API 29 emulator. The app is set to fullscreen, but both the statusbar and nav controls are still visible. To get them to go away, I've had to apply both this change, and my fork of the splashscreen plugin, which still has an open PR for the corresponding splashscreen fix: https://github.com/apache/cordova-plugin-splashscreen/pull/213
   
   <img width="1155" alt="Screen Shot 2019-11-03 at 6 34 35 PM" src="https://user-images.githubusercontent.com/10030156/68093985-b13b8580-fe69-11e9-9ff1-5cce5e2da98a.png">
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org