You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/23 12:51:27 UTC

[GitHub] [ignite] wirtsleg opened a new pull request #8077: IGNITE-13288 Mark activation and baseline events as internal.

wirtsleg opened a new pull request #8077:
URL: https://github.com/apache/ignite/pull/8077


   https://issues.apache.org/jira/browse/IGNITE-13288
   
   Marked the following events as internal:
   - EVT_CLUSTER_ACTIVATED
   - EVT_CLUSTER_DEACTIVATED
   - EVT_BASELINE_CHANGED
   - EVT_CLUSTER_STATE_CHANGED
   
   There are discovery events that are listened to by all nodes.
   It will be useful to include these events to listen on all nodes by default too. 
   All of them are rare, system and cluster-wide.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] dmekhanikov commented on pull request #8077: IGNITE-13288 Mark activation and baseline events as internal.

Posted by GitBox <gi...@apache.org>.
dmekhanikov commented on pull request #8077:
URL: https://github.com/apache/ignite/pull/8077#issuecomment-665626871


   I think we can make `testClusterActivationEventsOnOtherNode` more strict.
   Something like this:
   ```
   Ignite ignite_1 = startGrid(0);
   Ignite ignite_2 = startGrid(1);
   
   CountDownLatch deactivatedLatch = addDisposableLocalListener(ignite_2, EVT_CLUSTER_DEACTIVATED);
   CountDownLatch stateChangedLatch1 = addDisposableLocalListener(ignite_2, EVT_CLUSTER_STATE_CHANGED);
   
   ignite_1.cluster().state(ClusterState.INACTIVE);
   
   assertTrue(deactivatedLatch.await(2, TimeUnit.SECONDS));
   assertTrue(stateChangedLatch1.await(2, TimeUnit.SECONDS));
   
   CountDownLatch activatedLatch = addDisposableLocalListener(ignite_2, EVT_CLUSTER_ACTIVATED);
   CountDownLatch stateChangedLatch2 = addDisposableLocalListener(ignite_2, EVT_CLUSTER_STATE_CHANGED);
   
   ignite_1.cluster().state(ClusterState.ACTIVE);
   
   assertTrue(activatedLatch.await(2, TimeUnit.SECONDS));
   assertTrue(stateChangedLatch2.await(2, TimeUnit.SECONDS));
   ```
   
   Otherwise the fix looks good.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] asfgit closed pull request #8077: IGNITE-13288 Mark activation and baseline events as internal.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8077:
URL: https://github.com/apache/ignite/pull/8077


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org