You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/08 01:07:29 UTC

[GitHub] [solr] janhoy opened a new pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

janhoy opened a new pull request #606:
URL: https://github.com/apache/solr/pull/606


   https://issues.apache.org/jira/browse/SOLR-15907
   
   This is a rework of #518 with these improvemnts
   * Contrib -> module
   * New package name `org.apache.solr.security.jwt`
   * Separate commit for move, separate for formatting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801196551



##########
File path: versions.lock
##########
@@ -175,9 +175,10 @@ org.apache.zookeeper:zookeeper-jute:3.7.0 (1 constraints: 8a0d3a28)
 org.apiguardian:apiguardian-api:1.1.0 (3 constraints: 5f208479)
 org.aspectj:aspectjrt:1.8.0 (1 constraints: 0b050836)
 org.bitbucket.b_c:jose4j:0.7.7 (1 constraints: 10050736)
-org.bouncycastle:bcmail-jdk15on:1.69 (1 constraints: e4040431)
-org.bouncycastle:bcpkix-jdk15on:1.69 (1 constraints: e4040431)
-org.bouncycastle:bcprov-jdk15on:1.69 (1 constraints: e4040431)
+org.bouncycastle:bcmail-jdk15on:1.70 (1 constraints: e4040431)
+org.bouncycastle:bcpkix-jdk15on:1.70 (2 constraints: 73133c52)
+org.bouncycastle:bcprov-jdk15on:1.70 (3 constraints: 941ff808)
+org.bouncycastle:bcutil-jdk15on:1.70 (1 constraints: 580d0529)

Review comment:
       precommit fails because we are missing a license file for this new bc dependency - all of the BC libraries are MIT although we have them listed as "BSD_LIKE" - you can see the changes I made for it in the other PR.

##########
File path: solr/modules/jwt-auth/README.md
##########
@@ -0,0 +1,25 @@
+Apache Solr JWT Authentication Plugin
+=====================================
+
+Introduction
+------------
+Solr can support [JSON Web Token](https://en.wikipedia.org/wiki/JSON_Web_Token) (JWT) based 
+Bearer authentication with the use of the JWTAuthPlugin.
+
+This allows Solr to assert that a user is already authenticated with an external 
+[Identity Provider](https://en.wikipedia.org/wiki/Identity_provider) by validating 
+that the JWT formatted [access token](https://en.wikipedia.org/wiki/Access_token) 
+is digitally signed by the Identity Provider.
+
+The typical use case is to integrate Solr with an [OpenID Connect](https://en.wikipedia.org/wiki/OpenID_Connect) 
+enabled IdP.

Review comment:
       nit: is `IdP` a well known term for Identity Provider? Maybe wouldn't hurt to spell it out here, especially for somebody new that is exploring our contrive as a measure of project or maturity.

##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -118,6 +118,15 @@ configure(project(":solr:modules:analysis-extras")) {
   }
 }
 
+configure(project(":solr:modules:jwt-auth")) {
+  project.tasks.withType(RenderJavadocTask) {
+    // TODO: clean up split packages
+    javadocMissingIgnore = [
+        "org.apache.solr.security"

Review comment:
       Since you moved everything to o.a.s.security.jwt, do we still need this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801215314



##########
File path: solr/modules/jwt-auth/build.gradle
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+apply plugin: 'java-library'
+
+description = 'JWT / OpenID Connect / OAuth2 authentication plugin'
+
+dependencies {
+  implementation project(':solr:core')
+
+  implementation 'org.bitbucket.b_c:jose4j'
+
+  implementation 'commons-io:commons-io'
+  implementation 'org.apache.commons:commons-lang3'
+  implementation 'org.eclipse.jetty:jetty-client'
+  implementation ('com.google.guava:guava') { transitive = false }

Review comment:
       *Moderate OSS Vulnerability:*
   ### pkg:maven/com.google.guava/guava@25.1-jre
   0 Critical, 0 Severe, 1 Moderate, 0 Unknown vulnerabilities have been found across 1 dependencies
   
   <details>
     <summary><b>Components</b></summary><br/>
     <ul>
         <details>
           <summary><b>pkg:maven/com.google.guava/guava@25.1-jre</b></summary>
           <ul>
     <details>
       <summary><b>MODERATE Vulnerabilities (1)</b></summary><br/>
   <ul>
   
   > #### [CVE-2020-8908] A temp directory creation vulnerability exists in all versions of Guava, allowin...
   > A temp directory creation vulnerability exists in all versions of Guava, allowing an attacker with access to the machine to potentially access data in a temporary directory created by the Guava API com.google.common.io.Files.createTempDir(). By default, on unix-like systems, the created directory is world-readable (readable by an attacker with access to the system). The method in question has been marked @Deprecated in versions 30.0 and later and should not be used. For Android developers, we recommend choosing a temporary directory API provided by Android, such as context.getCacheDir(). For other Java developers, we recommend migrating to the Java 7 API java.nio.file.Files.createTempDirectory() which explicitly configures permissions of 700, or configuring the Java runtime&#39;s java.io.tmpdir system property to point to a location whose permissions are appropriately configured.
   >
   > **CVSS Score:** 3.3
   >
   > **CVSS Vector:** CVSS:3.0/AV:L/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:N
   
   </ul>
       </details>
           </ul>
         </details>
     </ul>
   </details>
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy closed pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy closed pull request #606:
URL: https://github.com/apache/solr/pull/606


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #606:
URL: https://github.com/apache/solr/pull/606#issuecomment-1032688291


   > @janhoy looks good. FYI depending on order of merge PR #604 will probably conflict with this. I'm happy to help fix conflicts either way.
   
   Ok, I announced Thursday as lazy consensus for merging this into 9.0. No problem for me if you merge the other one first, and then resolve conflicts on this one :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801249798



##########
File path: solr/licenses/bcutil-LICENSE-MIT.txt
##########
@@ -0,0 +1,15 @@
+Copyright (c) 2000-2010 The Legion Of The Bouncy Castle (http://www.bouncycastle.org)

Review comment:
       https://www.bouncycastle.org/license.html has updated dates (up to 2021). Not sure how much this matters.

##########
File path: solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginTest.java
##########
@@ -64,21 +64,30 @@
   // Shared with other tests
   static HashMap<String, Object> testJwk;
 
+  public static Path JWT_TEST_PATH() {
+    return getFile("solr/security").getParentFile().toPath();
+  }
+
   static {
-    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped in a JWK
+    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped
+    // in a JWK
     try {
       rsaJsonWebKey = RsaJwkGenerator.generateJwk(2048);
       rsaJsonWebKey.setKeyId("k1");
 
       testJwk = new HashMap<>();
       testJwk.put("kty", rsaJsonWebKey.getKeyType());
-      testJwk.put("e", BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));
+      testJwk.put(
+          "e",
+          BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));

Review comment:
       Some of this spotless formatting is so awkward, maybe we could go with a slightly longer line length to make this less bad? Probably not important right now anyway, but thinking ahead to when we apply the plugin other places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801204477



##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -118,6 +118,15 @@ configure(project(":solr:modules:analysis-extras")) {
   }
 }
 
+configure(project(":solr:modules:jwt-auth")) {
+  project.tasks.withType(RenderJavadocTask) {
+    // TODO: clean up split packages
+    javadocMissingIgnore = [
+        "org.apache.solr.security"

Review comment:
       You're rifht, removing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801343173



##########
File path: solr/modules/jwt-auth/build.gradle
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+apply plugin: 'java-library'
+
+description = 'JWT / OpenID Connect / OAuth2 authentication plugin'
+
+dependencies {
+  implementation project(':solr:core')
+
+  implementation 'org.bitbucket.b_c:jose4j'
+
+  implementation 'commons-io:commons-io'
+  implementation 'org.apache.commons:commons-lang3'
+  implementation 'org.eclipse.jetty:jetty-client'
+  implementation ('com.google.guava:guava') { transitive = false }

Review comment:
       Will be handled by #553 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801204596



##########
File path: solr/modules/jwt-auth/README.md
##########
@@ -0,0 +1,25 @@
+Apache Solr JWT Authentication Plugin
+=====================================
+
+Introduction
+------------
+Solr can support [JSON Web Token](https://en.wikipedia.org/wiki/JSON_Web_Token) (JWT) based 
+Bearer authentication with the use of the JWTAuthPlugin.
+
+This allows Solr to assert that a user is already authenticated with an external 
+[Identity Provider](https://en.wikipedia.org/wiki/Identity_provider) by validating 
+that the JWT formatted [access token](https://en.wikipedia.org/wiki/Access_token) 
+is digitally signed by the Identity Provider.
+
+The typical use case is to integrate Solr with an [OpenID Connect](https://en.wikipedia.org/wiki/OpenID_Connect) 
+enabled IdP.

Review comment:
       Spelling it out now.

##########
File path: versions.lock
##########
@@ -175,9 +175,10 @@ org.apache.zookeeper:zookeeper-jute:3.7.0 (1 constraints: 8a0d3a28)
 org.apiguardian:apiguardian-api:1.1.0 (3 constraints: 5f208479)
 org.aspectj:aspectjrt:1.8.0 (1 constraints: 0b050836)
 org.bitbucket.b_c:jose4j:0.7.7 (1 constraints: 10050736)
-org.bouncycastle:bcmail-jdk15on:1.69 (1 constraints: e4040431)
-org.bouncycastle:bcpkix-jdk15on:1.69 (1 constraints: e4040431)
-org.bouncycastle:bcprov-jdk15on:1.69 (1 constraints: e4040431)
+org.bouncycastle:bcmail-jdk15on:1.70 (1 constraints: e4040431)
+org.bouncycastle:bcpkix-jdk15on:1.70 (2 constraints: 73133c52)
+org.bouncycastle:bcprov-jdk15on:1.70 (3 constraints: 941ff808)
+org.bouncycastle:bcutil-jdk15on:1.70 (1 constraints: 580d0529)

Review comment:
       Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801207711



##########
File path: solr/core/build.gradle
##########
@@ -39,6 +39,9 @@ dependencies {
   api "org.apache.lucene:lucene-analysis-common"
   api "org.apache.lucene:lucene-queries"
 
+  // We export logging api with dependencies, which is useful for all contribs

Review comment:
       ```suggestion
     // We export logging api with dependencies, which is useful for all modules
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #606:
URL: https://github.com/apache/solr/pull/606#issuecomment-1032841173


   Closing in favor of #611 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dsmiley commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801753488



##########
File path: solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginTest.java
##########
@@ -64,21 +64,30 @@
   // Shared with other tests
   static HashMap<String, Object> testJwk;
 
+  public static Path JWT_TEST_PATH() {
+    return getFile("solr/security").getParentFile().toPath();
+  }
+
   static {
-    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped in a JWK
+    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped
+    // in a JWK
     try {
       rsaJsonWebKey = RsaJwkGenerator.generateJwk(2048);
       rsaJsonWebKey.setKeyId("k1");
 
       testJwk = new HashMap<>();
       testJwk.put("kty", rsaJsonWebKey.getKeyType());
-      testJwk.put("e", BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));
+      testJwk.put(
+          "e",
+          BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));

Review comment:
       Can we please apply formatting in a separate PR/commit and then exclude this from `.git-blame-ignore-revs` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801208411



##########
File path: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java
##########
@@ -95,11 +95,11 @@ public final boolean authenticate(HttpServletRequest request, HttpServletRespons
     }
   }
 
-  HttpServletRequest wrapWithPrincipal(HttpServletRequest request, Principal principal) {
+  protected HttpServletRequest wrapWithPrincipal(HttpServletRequest request, Principal principal) {

Review comment:
       Example of base-class method that required same-package for plugins. With this change the auth plugins can be any package.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #606:
URL: https://github.com/apache/solr/pull/606#discussion_r801802481



##########
File path: solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginTest.java
##########
@@ -64,21 +64,30 @@
   // Shared with other tests
   static HashMap<String, Object> testJwk;
 
+  public static Path JWT_TEST_PATH() {
+    return getFile("solr/security").getParentFile().toPath();
+  }
+
   static {
-    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped in a JWK
+    // Generate an RSA key pair, which will be used for signing and verification of the JWT, wrapped
+    // in a JWK
     try {
       rsaJsonWebKey = RsaJwkGenerator.generateJwk(2048);
       rsaJsonWebKey.setKeyId("k1");
 
       testJwk = new HashMap<>();
       testJwk.put("kty", rsaJsonWebKey.getKeyType());
-      testJwk.put("e", BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));
+      testJwk.put(
+          "e",
+          BigEndianBigInteger.toBase64Url(rsaJsonWebKey.getRsaPublicKey().getPublicExponent()));

Review comment:
       Did a shot in #611 
   I first applied Spotless on JWT classes while still in solr-core. We can merge that one commit as a separate PR first.
   Then rebased this branch on top, with some quashing etc to make the edit history more clean.
   Hope you like it :) 
   
   I did not dare to force-push the same to this same branch. No idea what would happen to the PR and review comment history if I did. So we can close this and finalize in #611 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org