You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by je...@apache.org on 2003/02/17 03:47:11 UTC

cvs commit: httpd-2.0/modules/filters config.m4

jerenkrantz    2003/02/16 18:47:11

  Modified:    modules/filters config.m4
  Log:
  Switch mod_deflate to 'most' status now.  It's stable enough and will disable
  itself if zlib isn't found.
  
  PR: 15786
  
  Revision  Changes    Path
  1.11      +1 -1      httpd-2.0/modules/filters/config.m4
  
  Index: config.m4
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/filters/config.m4,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -u -r1.10 -r1.11
  --- config.m4	28 Nov 2002 23:02:44 -0000	1.10
  +++ config.m4	17 Feb 2003 02:47:11 -0000	1.11
  @@ -9,7 +9,7 @@
   
   APR_ADDTO(LT_LDFLAGS,-export-dynamic)
   
  -APACHE_MODULE(deflate, Deflate transfer encoding support, , , no, [
  +APACHE_MODULE(deflate, Deflate transfer encoding support, , , most, [
     AC_ARG_WITH(z, APACHE_HELP_STRING(--with-z=DIR,use a specific zlib library),
     [
       if test "x$withval" != "xyes" && test "x$withval" != "x"; then
  
  
  

Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by André Malo <nd...@perlig.de>.
* Aaron Bannert wrote:

> Does mod_deflate need something special to be enabled,
> other than the LoadModule line?

Yes. It must be manually inserted into the filter chain.

nd
-- 
s  s^saaaaaoaaaoaaaaooooaaoaaaomaaaa  a  alataa  aaoat  a  a
a maoaa a laoata  a  oia a o  a m a  o  alaoooat aaool aaoaa
matooololaaatoto  aaa o a  o ms;s;\s;s;g;y;s;:;s;y#mailto: #
 \51/\134\137| http://www.perlig.de #;print;# > nd@perlig.de

Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Cliff Woolley <jw...@virginia.edu>.
On Mon, 17 Feb 2003, Joshua Slive wrote:

> But it won't actually activate the filter, will it?

Not unless it's already configured within an <IfModule> section.

--Cliff

Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Aaron Bannert <aa...@clove.org>.
On Monday, February 17, 2003, at 07:30  AM, Joshua Slive wrote:
>> The current build/install system will add a LoadModule line for
>> each DSO that it installs.
>
> But it won't actually activate the filter, will it?

Does mod_deflate need something special to be enabled,
other than the LoadModule line?

-aaron


Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Joshua Slive <jo...@slive.ca>.
On Mon, 17 Feb 2003, Aaron Bannert wrote:
> > In my opinion, --enable-modules=most should give you essentially all
> > the
> > modules that can be compiled unless there is a very good reason to
> > exclude
> > one.  That is what people expect.  But just because the module is
> > compiled, doesn't mean it should be activated in the default config
> > file.
>
> The current build/install system will add a LoadModule line for
> each DSO that it installs.

But it won't actually activate the filter, will it?

Joshua.

Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Aaron Bannert <aa...@clove.org>.
On Monday, February 17, 2003, at 06:45  AM, Joshua Slive wrote:

>
> On Mon, 17 Feb 2003, Aaron Bannert wrote:
>
>> Being enabled or disable by default isn't solely based on
>> begin stable. I personally don't think mod_deflate should
>> be enabled by default, especially given its track record
>> of browser incompatibility/bugs.
>
> In my opinion, --enable-modules=most should give you essentially all 
> the
> modules that can be compiled unless there is a very good reason to 
> exclude
> one.  That is what people expect.  But just because the module is
> compiled, doesn't mean it should be activated in the default config 
> file.

The current build/install system will add a LoadModule line for
each DSO that it installs.

-aaron


Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Joshua Slive <jo...@slive.ca>.
On Mon, 17 Feb 2003, Aaron Bannert wrote:

> Being enabled or disable by default isn't solely based on
> begin stable. I personally don't think mod_deflate should
> be enabled by default, especially given its track record
> of browser incompatibility/bugs.

In my opinion, --enable-modules=most should give you essentially all the
modules that can be compiled unless there is a very good reason to exclude
one.  That is what people expect.  But just because the module is
compiled, doesn't mean it should be activated in the default config file.

Joshau.

Re: cvs commit: httpd-2.0/modules/filters config.m4

Posted by Aaron Bannert <aa...@clove.org>.
Being enabled or disable by default isn't solely based on
begin stable. I personally don't think mod_deflate should
be enabled by default, especially given its track record
of browser incompatibility/bugs.

-aaron


On Sunday, February 16, 2003, at 06:47  PM, jerenkrantz@apache.org 
wrote:

> jerenkrantz    2003/02/16 18:47:11
>
>   Modified:    modules/filters config.m4
>   Log:
>   Switch mod_deflate to 'most' status now.  It's stable enough and 
> will disable
>   itself if zlib isn't found.