You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org> on 2009/01/15 14:56:59 UTC
[jira] Created: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
---------------------------------------------------------------------------------------------
Key: DIRSTUDIO-447
URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
Project: Directory Studio
Issue Type: Improvement
Reporter: Pierre-Arnaud Marcelot
Assignee: Pierre-Arnaud Marcelot
Fix For: 1.3.1, 1.4.0
Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-447:
---------------------------------------------
Fix Version/s: 1.5.4
2.0.0
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Fix For: 1.5.4, 2.0.0
>
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447-mod2.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Keheliya Gallaba (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855821#action_12855821 ]
Keheliya Gallaba commented on DIRSTUDIO-447:
--------------------------------------------
Thank you Seelmann for the feedback.
I'll discuss in IRC to clarify the idea and come up with a second patch.
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seelmann updated DIRSTUDIO-447:
--------------------------------------
Fix Version/s: (was: 1.5.0)
postponed
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859311#action_12859311 ]
Pierre-Arnaud Marcelot commented on DIRSTUDIO-447:
--------------------------------------------------
Hi Keheliya,
A few comments on your patch.
The fix on the SearchView is working good. :)
However, the fix on the other ATs or OCs selection dialogs is not working as we would expect the dialog to behave.
Everything works fine when using ? and * symbol, but we expect the list to remove item while typing and thus 'implicity' put a ".*" search pattern at the end of the regex.
Here's an example:
If I want to find the object class name "automount", I will start by typing the character 'a'.
This expected behavior of the dialog is to display in the list all object classes starting with the character 'a' (even if I did ended my search with a '*').
Then I'll type the character 'u', which will narrow down the list to only two elements "automount" and "automountMap".
This is more ergonomic in the way that you're narrowing the list as long as you type and once you see the element you're interested in, you simply press the down key to select it.
This is exactly what is done in Eclipse in the Class/Interface selection dialog and it's good to maintain the same concept in Studio for the user.
I'm sure you weren't aware of this requirement at the time you wrote the patch.
One more comment.
At Directory, we are using specific rules for code formatting and your patch does not follow them.
Especially, we replace every tab by 4 spaces in your case.
I encourage you to load our code templates and code formatting files in your own Eclipse.
These files are located here:
http://svn.apache.org/repos/asf/directory/project/trunk/resources/codetemplates.xml
http://svn.apache.org/repos/asf/directory/project/trunk/resources/formatting.xml
One last thing.
When you have multiple strings on the same line, strings that don't need to be translated and extracted in properties files, you should add as many "//$NON-NLS-X$" elements as strings you have.
For example, instead of this:
searchRegexp = searchText.replaceAll( "\\*", "[\\\\S]*" ); //$NON-NLS-1$
you should have that:
searchRegexp = searchText.replaceAll( "\\*", "[\\\\S]*" ); //$NON-NLS-1$ //$NON-NLS-2$
Thanks
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSTUDIO-447) Add the ability to use wildcards (?,
*) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot closed DIRSTUDIO-447.
--------------------------------------------
Resolution: Fixed
Fixed at revision 936652.
Applied patch from Keheliya Gallaba.
http://svn.apache.org/viewvc?rev=936652&view=rev
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447-mod2.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Keheliya Gallaba (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keheliya Gallaba updated DIRSTUDIO-447:
---------------------------------------
Attachment: DIRSTUDIO-447-mod.patch
Modified Patch Added.
Wildcards (?, *) support in the ATs or OCs selection dialogs and schema search view.
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858396#action_12858396 ]
Pierre-Arnaud Marcelot commented on DIRSTUDIO-447:
--------------------------------------------------
Thanks Keheliya!
I'll take some time to review these patches.
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855642#action_12855642 ]
Stefan Seelmann commented on DIRSTUDIO-447:
-------------------------------------------
Thanks for the patch.
I'm not the creator of this issues but I just want to give some quick feedback as Pierre-Arnaud is on vacations.
Your patch is for the schema search view (and useful though): http://directory.apache.org/studio/static/users_guide/schema_editor/gettingstarted_views_search.html
However I *think* Pierre-Arnaud created this issue to improve the dialogs for selection of object classes (OC) and attribute types (AT). They popup if you press the add buttons in the object class editor: http://directory.apache.org/studio/static/users_guide/schema_editor/gettingstarted_editors_object_class.html. The OC dialog pops up if you press the add button for the "Superior classes" field. The AT dialog pops up if you press the add button in the "Mandatory attributes" or "Optional attributes" section.
It would be cool if you could provide a second patch :-)
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859738#action_12859738 ]
Pierre-Arnaud Marcelot commented on DIRSTUDIO-447:
--------------------------------------------------
Hi Keheliya,
The dialogs are now working perfectly and the formatting of the patch is ok and following our standards.
I'll push the modifications of your patch to trunk. :)
Thanks for fixing this.
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447-mod2.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Keheliya Gallaba (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keheliya Gallaba updated DIRSTUDIO-447:
---------------------------------------
Attachment: DIRSTUDIO-447-mod2.patch
Modified patch added.
Fixed ATs or OCs selection dialogs searches to be more ergonomic and followed Apache Directory code formatting guidelines.
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447-mod.patch, DIRSTUDIO-447-mod2.patch, DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-447:
---------------------------------------------
Fix Version/s: (was: 1.4.0)
1.5.0
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Fix For: 1.5.0
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Keheliya Gallaba (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keheliya Gallaba updated DIRSTUDIO-447:
---------------------------------------
Attachment: DIRSTUDIO-447.patch
Adding the patch
This enables the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search.
Eg:
sh?? will return 'ship', 'shut' but not 'shock'
sh* will return 'shock' but not 'bash'
*sh will return 'bash'
*sh* will return 'bash', 'ship' or 'fisher'
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Attachments: DIRSTUDIO-447.patch
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-447) Add the ability to use wildcards
(?, *) in the ATs or OCs selection dialog to ease the search
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-447:
---------------------------------------------
Component/s: studio-schemaeditor
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
> ---------------------------------------------------------------------------------------------
>
> Key: DIRSTUDIO-447
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-447
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-schemaeditor
> Reporter: Pierre-Arnaud Marcelot
> Assignee: Pierre-Arnaud Marcelot
> Fix For: 1.4.0
>
>
> Add the ability to use wildcards (?, *) in the ATs or OCs selection dialog to ease the search
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.