You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@camel.apache.org by "Andrea Cosentino (Jira)" <ji...@apache.org> on 2022/01/11 15:48:00 UTC

[jira] [Commented] (CAMEL-17473) camel-github: startingSha=last doesn't work properly

    [ https://issues.apache.org/jira/browse/CAMEL-17473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472842#comment-17472842 ] 

Andrea Cosentino commented on CAMEL-17473:
------------------------------------------

I think this is a duplicate of another issue i was working on. Thanks a lot Andrea for that patch! 

> camel-github: startingSha=last doesn't work properly
> ----------------------------------------------------
>
>                 Key: CAMEL-17473
>                 URL: https://issues.apache.org/jira/browse/CAMEL-17473
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-github
>    Affects Versions: 3.14.0
>            Reporter: Andrea Pilo
>            Priority: Major
>             Fix For: 3.15.0, 3.14.1
>
>         Attachments: mypatch.patch
>
>
> When *startingSha* is set to "last" the component does not start from the last commit.
> The problem is related to the fact that the egit eclipse library returns the list of commits in order (from latest to oldest) but in the code the opposite is assumed: [here|https://github.com/apache/camel/blob/0e4f4923440c3ef34306595ab70447879bdab4e5/components/camel-github/src/main/java/org/apache/camel/component/github/consumer/CommitConsumer.java#L77]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)