[I] Proxy parameters [airflow]

["morelgeorge (via GitHub)" <gi...@apache.org>]

morelgeorge opened a new issue, #61197:
URL: https://github.com/apache/airflow/issues/61197

   ### Apache Airflow Provider(s)
   
   microsoft-azure
   
   ### Versions of Apache Airflow Providers
   
   - apache-airflow-providers-microsoft-azure 12.10.1
   
   ### Apache Airflow version
   
   3.1.3
   
   ### Operating System
   
   Rhel 9.6
   
   ### Deployment
   
   Virtualenv installation
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   Hello, 
   we are facing an issue when we are trying to connect to a Power BI using standard proxies attribute. We are using proxies parameters like following: 
   
   > {
   >         "http": "http://{Username}:{Password}@{ProxyURL}:{Port}"
   >         "https":"http://{Username}:{Password}@{ProxyURL}:{Port}"
   >}
   
   However, the MSAL Proxy parameter that is used when communicating with Azure services is still set to None. Based on our testing it is because of missing _Authority_ variable which is not retrieved from the connection. 
   
   We are using Power BI connection using Service Principal account with ClientID, Secret and Tenant parameters filled. 
   
   ### What you think should happen instead
   
   In KiotaRequestAdapterHook function **to_msal_proxies** is a statement that sets up proxies to None in case there is missing Authority or Proxies. That is the root cause of the issue. **We do not retrieve Authority value from connection.**
   
   ### How to reproduce
   
   Test connection to a Power BI service with using proxies parameter. 
   
   ### Anything else
   
   I am not sure why the Authority is needed in this case. We can fix it by updating the if statement in to_msal_proxies function, but I am not sure if it is correct approach. 
   
   Also, one interesting thing - In the DAG log all proxies values are written, even when they are using sensitive values. The Redact function does not work properly.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Proxies are not set when using microsoft-azure provider for Power BI [airflow]

["dabla (via GitHub)" <gi...@apache.org>]

dabla closed issue #61197: Proxies are not set when using microsoft-azure provider for Power BI
URL: https://github.com/apache/airflow/issues/61197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Proxies are not set when using microsoft-azure provider for Power BI [airflow]

["morelgeorge (via GitHub)" <gi...@apache.org>]

morelgeorge commented on issue #61197:
URL: https://github.com/apache/airflow/issues/61197#issuecomment-3829539312

   Based on my further investigation this issue is not a bug. Provider is using MSAL Proxy when _proxies_ parameters are set. However, in my opinion there is a confusing [Power BI connection documentation](https://airflow.apache.org/docs/apache-airflow-providers-microsoft-azure/stable/connections/powerbi.html).
   
   I did some internal testing and figured out, that to be able to connect to a Power BI with using a proxy server I had to add extra parameter to a connection: 
   
   > "authority": login.microsoftonline.com
   
   In my opinion this setup is very-well documented in [MS Graph connection](https://airflow.apache.org/docs/apache-airflow-providers-microsoft-azure/stable/connections/msgraph.html) documentation. But this is not mentioned at all in Power BI connection documentation. You need to go deep in code to understand how provider works. This can be a little bit confusing when you want to  connect to a Power BI service with using a proxy. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org