You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Bastian Hofmann (JIRA)" <ji...@apache.org> on 2010/07/15 13:13:54 UTC

[jira] Created: (SHINDIG-1385) Wrong http_url in OAuthRequest class if shindig is running on a port other than 80

Wrong http_url in OAuthRequest class if shindig is running on a port other than 80
----------------------------------------------------------------------------------

                 Key: SHINDIG-1385
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1385
             Project: Shindig
          Issue Type: Bug
          Components: PHP
            Reporter: Bastian Hofmann


If Shindig is running on an other port than 80, the generated http_url in the OAuthRequest class will be for example

http://shindigdomain:8181:8181

instead of http://shindigdomain:8181

The following patch fixes this:

Index: php/external/OAuth/OAuth.php
===================================================================
250c250
<                               '://' . $_SERVER['HTTP_HOST'] .
---
>                               '://' . $_SERVER['SERVER_NAME'] .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1385) Wrong http_url in OAuthRequest class if shindig is running on a port other than 80

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889784#action_12889784 ] 

Paul Lindner commented on SHINDIG-1385:
---------------------------------------

Can we get this patched in the upstream OAuth.php?




> Wrong http_url in OAuthRequest class if shindig is running on a port other than 80
> ----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1385
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1385
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Bastian Hofmann
>
> If Shindig is running on an other port than 80, the generated http_url in the OAuthRequest class will be for example
> http://shindigdomain:8181:8181
> instead of http://shindigdomain:8181
> The following patch fixes this:
> Index: php/external/OAuth/OAuth.php
> ===================================================================
> 250c250
> <                               '://' . $_SERVER['HTTP_HOST'] .
> ---
> >                               '://' . $_SERVER['SERVER_NAME'] .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-1385) Wrong http_url in OAuthRequest class if shindig is running on a port other than 80

Posted by "Bastian Hofmann (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889799#action_12889799 ] 

Bastian Hofmann commented on SHINDIG-1385:
------------------------------------------

i just saw that this issue is already filed for the OAuth library:

http://code.google.com/p/oauth/issues/detail?id=170

> Wrong http_url in OAuthRequest class if shindig is running on a port other than 80
> ----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1385
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1385
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Bastian Hofmann
>
> If Shindig is running on an other port than 80, the generated http_url in the OAuthRequest class will be for example
> http://shindigdomain:8181:8181
> instead of http://shindigdomain:8181
> The following patch fixes this:
> Index: php/external/OAuth/OAuth.php
> ===================================================================
> 250c250
> <                               '://' . $_SERVER['HTTP_HOST'] .
> ---
> >                               '://' . $_SERVER['SERVER_NAME'] .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1385) Wrong http_url in OAuthRequest class if shindig is running on a port other than 80

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1385.
-----------------------------------

    Fix Version/s: 2.0.0-RC1
       Resolution: Fixed

patched in..

> Wrong http_url in OAuthRequest class if shindig is running on a port other than 80
> ----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1385
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1385
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>            Reporter: Bastian Hofmann
>             Fix For: 2.0.0-RC1
>
>
> If Shindig is running on an other port than 80, the generated http_url in the OAuthRequest class will be for example
> http://shindigdomain:8181:8181
> instead of http://shindigdomain:8181
> The following patch fixes this:
> Index: php/external/OAuth/OAuth.php
> ===================================================================
> 250c250
> <                               '://' . $_SERVER['HTTP_HOST'] .
> ---
> >                               '://' . $_SERVER['SERVER_NAME'] .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.