You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/10/02 07:15:27 UTC
[PR] CAMEL-25229: camel-hazelcast - warn and document when a user-supplied config has no serialization filter [camel]
oscerd opened a new pull request, #27255:
URL: https://github.com/apache/camel/pull/27255
## Summary
Follow-up to [CAMEL-23414](https://issues.apache.org/jira/browse/CAMEL-23414). Camel applies its default `JavaSerializationFilterConfig` only to the Hazelcast configurations it builds itself, and uses a user-supplied configuration unchanged. So far this was described only in the 4.18 and 4.21 upgrade guides. This PR makes it visible:
- **Docs**: a new "Java serialization filter" section in `hazelcast-summary.adoc`. It explains which instances get Camel's default filter and that a user-supplied `Config`, `ClientConfig`, `hazelcastConfigUri` or instance is used as-is. It also shows how to declare a filter in XML and in Java (member and client), and the JVM-wide `jdk.serialFilter` alternative.
- **WARN**: `HazelcastDefaultComponent` logs a WARN, once per managed instance, when it starts a member or client from a user-supplied `Config` or `ClientConfig` (bean or `hazelcastConfigUri`). It only does so when that configuration declares no `JavaSerializationFilterConfig` and no JVM-wide `jdk.serialFilter` is set. The user's configuration is still not modified.
- **Upgrade guide**: a note in the 4.23 `camel-hazelcast` section.
Apart from the new log line, nothing changes at runtime.
## Tests
- New `HazelcastUserConfigSerializationFilterWarningTest`:
- the WARN is logged once for a user `Config` without a filter, with two endpoints sharing a named instance;
- it is not logged when a filter is declared;
- it is not logged for the configuration Camel builds by default;
- it is logged for a user `ClientConfig` in client mode, against a local member.
- Revert check: without the production change, the two "warns" tests fail (`expected: <1> but was: <0>`).
- camel-hazelcast module: 237 tests, 0 failures.
- Full reactor `mvn clean install -DskipTests -DskipITs`, which also regenerates the catalog copy of the component doc.
- After rebasing onto current `main`, the targeted tests were re-run. Upstream had no changes in camel-hazelcast or in
its catalog doc copy in the meantime.
- Checked against Hazelcast 5.4.0:
- the documented XML (member and client) and Java snippets produce the expected filter;
- Hazelcast's Java deserialization honours a JVM-wide `jdk.serialFilter` when no `JavaSerializationFilterConfig` is set, which is why the WARN is skipped in that case.
Jira: https://issues.apache.org/jira/browse/CAMEL-25229
_Claude Code on behalf of Andrea Cosentino_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25229: camel-hazelcast - warn and document when a user-supplied config has no serialization filter [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27255:
URL: https://github.com/apache/camel/pull/27255#issuecomment-5947640474
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `catalog/camel-catalog`
- `components/camel-hazelcast`
- `docs`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 9 of 697 tested, 25 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **9 affected modules** (current approach: 9).
**Skip-tests mode would test 9 modules** (3 direct + 8 downstream), **skip tests for 25** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (9)</summary>
- `camel-hazelcast` ← components/camel-hazelcast/src/main/docs/hazelcast-summary.adoc, components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/HazelcastDefaultComponent.java, components/camel-hazelcast/src/test/java/org/apache/camel/component/hazelcast/HazelcastUserConfigSerializationFilterWarningTest.java
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-route-parser
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-yaml-dsl-validator` ← downstream of org.apache.camel:camel-catalog
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (25)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (36 modules, 5m 46s total)</summary>
**Total reactor time:** 5m 46s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Launcher | 49.4s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 46.0s | SUCCESS |
| Camel :: JBang :: MCP | 44.7s | SUCCESS |
| Camel :: Component DSL | 28.0s | SUCCESS |
| Camel :: Catalog :: Camel Catalog | 24.1s | SUCCESS |
| Camel :: YAML DSL | 20.0s | SUCCESS |
| Camel :: YAML DSL :: Validator | 19.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 19.0s | SUCCESS |
| Camel :: Docs | 15.8s | SUCCESS |
| Camel :: Kamelet Main | 10.3s | SUCCESS |
| Camel :: YAML DSL :: Deserializers | 8.3s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 8.3s | SUCCESS |
| Camel :: Catalog :: Camel Route Parser | 8.2s | SUCCESS |
| Camel :: Catalog :: Camel Report Maven Plugin | 7.3s | SUCCESS |
| Camel :: All Components Sync point | 5.4s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 5.2s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 4.3s | SUCCESS |
| Camel :: Catalog :: Maven | 3.5s | SUCCESS |
| Camel :: YAML DSL :: Maven Plugins | 3.4s | SUCCESS |
| Camel :: Catalog :: Suggest (deprecated) | 2.6s | SUCCESS |
| Camel :: Assembly | 1.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.2s | SUCCESS |
| Camel :: Coverage | 1.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.2s | SUCCESS |
| Camel :: JBang :: Integration tests | 1.2s | SUCCESS |
| Camel :: Catalog :: Dummy Component | 1.0s | SUCCESS |
| Camel :: Endpoint DSL :: Support | 0.9s | SUCCESS |
| Camel :: Catalog :: Console | 0.8s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 0.8s | SUCCESS |
| Camel :: Launcher :: Container | 0.7s | SUCCESS |
| Camel :: JBang :: Main | 0.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.5s | SUCCESS |
| Camel :: Endpoint DSL | n/a | |
| Camel :: HazelCast | n/a | |
| Camel :: Integration Tests | n/a | |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Launcher` (49.4s)
- `Camel :: JBang :: Plugin :: TUI` (46.0s)
- `Camel :: JBang :: MCP` (44.7s)
- `Camel :: Component DSL` (28.0s)
- `Camel :: Catalog :: Camel Catalog` (24.1s)
- `Camel :: YAML DSL` (20.0s)
- `Camel :: YAML DSL :: Validator` (19.9s)
- `Camel :: JBang :: Plugin :: Kubernetes` (19.0s)
- `Camel :: Docs` (15.8s)
- `Camel :: Kamelet Main` (10.3s)
- `Camel :: YAML DSL :: Deserializers` (8.3s)
- `Camel :: JBang :: Plugin :: Testing` (8.3s)
- `Camel :: Catalog :: Camel Route Parser` (8.2s)
- `Camel :: Catalog :: Camel Report Maven Plugin` (7.3s)
- `Camel :: All Components Sync point` (5.4s)
- `Camel :: JBang :: Plugin :: Validate` (5.2s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (4.3s)
- `Camel :: Catalog :: Maven` (3.5s)
- `Camel :: YAML DSL :: Maven Plugins` (3.4s)
- `Camel :: Catalog :: Suggest (deprecated)` (2.6s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/36977617699)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25229: camel-hazelcast - warn and document when a user-supplied config has no serialization filter [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27255:
URL: https://github.com/apache/camel/pull/27255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25229: camel-hazelcast - warn and document when a user-supplied config has no serialization filter [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27255:
URL: https://github.com/apache/camel/pull/27255#issuecomment-5947235141
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org