You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hohoho1886 (via GitHub)" <gi...@apache.org> on 2026/10/17 21:28:44 UTC

[PR] [improve][client] Implement schema cache to improve performance [pulsar]

hohoho1886 opened a new pull request, #26970:
URL: https://github.com/apache/pulsar/pull/26970

   <!--
   ### Contribution Checklist
   
     - PR title format should be *[type][component] summary*. The valid `[type]` and `[component]`/scope
       prefixes are enforced by CI (see `.github/workflows/ci-semantic-pull-request.yml`); for details,
       see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - The **Motivation** and **Modifications** sections are required: explain *why* (the problem/context)
       and *what/how* (the change). A title alone, or a description that only restates the title, is not enough.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
     - Each commit in the pull request has a meaningful commit message
   
     - For the local build/test/PR workflow see `CONTRIBUTING.md`, and for coding conventions see
       `CODING.md`. If you use an AI coding assistant, see `AGENTS.md`.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   <!-- Either this PR fixes/closes an issue — use "Fixes #xyz" or, equivalently, "Closes #xyz", -->
   
   Fixes #23707
   
   <!-- or this PR is one task of an issue -->
   
   
   <!-- If the PR belongs to a PIP, please add the PIP link here -->
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
   
   ### Motivation
   Schema creation (e.g., `Schema.AVRO(SomeClass.class)`) is fairly CPU intensive. It would be useful it there would be a weak reference cache for caching the schema instance.
   
   ### Modifications
   - Added a weak reference cache for the schema
     instances created by `Schema.AVRO`, `Schema.JSON` and `Schema.PROTOBUF.`
   - Cached instances are never returned directly, a clone of the cached instance is returned instead.
   - Each cache is guarded by its own lock, so concurrent callers cannot
     corrupt the map or build the same schema twice.
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [improve][client] Implement schema cache to improve performance [pulsar]

Posted by "hohoho1886 (via GitHub)" <gi...@apache.org>.
hohoho1886 closed pull request #26970: [improve][client] Implement schema cache to improve performance
URL: https://github.com/apache/pulsar/pull/26970


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org