[jira] [Commented] (JCRVLT-279) Emit warning/error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679735#comment-16679735 ] 

Konrad Windszus commented on JCRVLT-279:
----------------------------------------

With JCRVLT-320 the order became less predicatable due to the usage of {{ConcurrentJarCreator}} under the hood. 
[~tripod] Can you give a hint, why the content are added in such a complicated way to the final ZIP (in https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/f165aac9c02025650d01d1ee6997448c375796fe/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L211)? As I said, the order is no longer predicable so is this now only there to make sure not everything is included in the package but only those parts which are covered by filter rules?

> Emit warning/error in case embedded file/subpackage is overwritten by jcrRootSourceDirectory
> --------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-279
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-279
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin
>    Affects Versions: package-maven-plugin-1.0.1
>            Reporter: Konrad Windszus
>            Priority: Minor
>
> Due to errorneous project setup it may sometimes happen that the {{jcrRootSourceDirectory}} inadvertently contains the to be embedded file. Since the {{jcrRootSourceDirectory}} is having a higher precedence all files in there overwrite previously embedded files. In that case a warning/error should be emitted. The same for sub packages.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)