[GitHub] [pinot] itschrispeck commented on a diff in pull request #11000: add support for mv cols with realtime lucene index

["itschrispeck (via GitHub)" <gi...@apache.org>]

itschrispeck commented on code in PR #11000:
URL: https://github.com/apache/pinot/pull/11000#discussion_r1247626645


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableTextIndex.java:
##########
@@ -31,12 +31,18 @@ default void add(@Nonnull Object value, int dictId, int docId) {
 
   @Override
   default void add(@Nonnull Object[] values, @Nullable int[] dictIds, int docId) {
-    throw new UnsupportedOperationException("Mutable text indexes are not supported for multi-valued columns");
+    add((String[]) values);
   }
 
   /**
    * Index the document
    * @param document the document as a string
    */
   void add(String document);
+
+  /**
+   * Index the multi-value document
+   * @param document the document as an array of Strings
+   */
+  void add(String[] document);

Review Comment:
   thanks for the comments! addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org