You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Aman1919 (via GitHub)" <gi...@apache.org> on 2023/02/18 23:08:04 UTC
[GitHub] [echarts] Aman1919 opened a new pull request, #18285: fix decal in aria
Aman1919 opened a new pull request, #18285:
URL: https://github.com/apache/echarts/pull/18285
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix issue - https://github.com/apache/echarts/issues/18118#issue-1512698774
"series-sunburst.data.itemStyle.decal" is able to override "aria.decal. decals"
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How does it behave after the fixing?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1458058146
i did some changes and after that result is looking like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix decal in aria [echarts]
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 closed pull request #18285: fix decal in aria
URL: https://github.com/apache/echarts/pull/18285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1498510948
@Ovilia did some changes and added another case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] github-actions[bot] commented on pull request #18285: fix decal in aria
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1661487843
<!-- ECHARTS_PR_PREVIEW -->
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18285@03a1859
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1660984011
@Ovilia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1506352738
> @Aman1919 Yes, in the above image, if two items have the same color, they should have the same decal.
I think color is being added by value of children items . is this not correct Color shouldn't be added like this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #18285:
URL: https://github.com/apache/echarts/pull/18285#discussion_r1160387195
##########
src/visual/aria.ts:
##########
@@ -82,12 +82,10 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
if (ecModel.isSeriesFiltered(seriesModel)) {
return;
}
- if (zrUtil.isFunction(seriesModel.enableAriaDecal)) {
- // Let series define how to use decal palette on data
- seriesModel.enableAriaDecal();
+ if (zrUtil.isFunction(seriesModel.enableAriaDecal)) {
Review Comment:
Please revert the changes (indent) here.
##########
src/data/Tree.ts:
##########
@@ -265,7 +265,6 @@ export class TreeNode {
getVisual(key: string): unknown {
return this.hostTree.data.getItemVisual(this.dataIndex, key as any);
}
Review Comment:
Please revert the change here.
##########
test/sunburst-ariaDecal2.html:
##########
@@ -0,0 +1,186 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<html>
+ <head>
+ <meta charset="utf-8" />
+ <script src="lib/simpleRequire.js"></script>
+ <script src="lib/config.js"></script>
+ </head>
+ <body>
+ <style>
+ html,
+ body,
+ #main {
+ width: 100%;
+ height: 100%;
+ /* background-image: url(old_mathematics.png); */
+ /* background-repeat: repeat; */
+ }
+ </style>
+ <div id="main"></div>
+ <script>
+ var chart;
Review Comment:
The test result of this case is not correct. Since "Grandpa", "Nancy" and "Mike" have different colors, they should also have different decals, otherwise, decal is not useful at all.
Besides, this case can be put into `sunburst-ariaDecal.html` rather than in a seperate file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1514069938
No. This will break the original design of sunburst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1575660918
so, lower levels node should be of lighter color than the upper level ? Could you suggest me something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18285: fix decal in aria
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1435788540
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #18285:
URL: https://github.com/apache/echarts/pull/18285#discussion_r1116457232
##########
src/data/Tree.ts:
##########
@@ -265,6 +265,9 @@ export class TreeNode {
getVisual(key: string): unknown {
return this.hostTree.data.getItemVisual(this.dataIndex, key as any);
}
+ getDecal(key: string): unknown {
Review Comment:
Why is `key` necessary` here? It's always `'decal'`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #18285:
URL: https://github.com/apache/echarts/pull/18285#discussion_r1116457232
##########
src/data/Tree.ts:
##########
@@ -265,6 +265,9 @@ export class TreeNode {
getVisual(key: string): unknown {
return this.hostTree.data.getItemVisual(this.dataIndex, key as any);
}
+ getDecal(key: string): unknown {
Review Comment:
Why is `key` necessary here? It's always `'decal'`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on a diff in pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on code in PR #18285:
URL: https://github.com/apache/echarts/pull/18285#discussion_r1150269202
##########
src/visual/aria.ts:
##########
@@ -82,15 +82,10 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
if (ecModel.isSeriesFiltered(seriesModel)) {
return;
}
- if (zrUtil.isFunction(seriesModel.enableAriaDecal)) {
Review Comment:
Do not remove these lines. You can remove the `enableAriaDecal` in `SunburstSeries.ts`.
##########
src/chart/sunburst/SunburstSeries.ts:
##########
@@ -164,7 +164,7 @@ class SunburstSeriesModel extends SeriesModel<SunburstSeriesOption> {
static readonly type = 'series.sunburst';
readonly type = SunburstSeriesModel.type;
- ignoreStyleOnData = true;
+ ignoreStyleOnData = false;
Review Comment:
Remove this line and `ignoreStyleOnData` is set to be `false` by default.
##########
test/sunburst-ariaDecal.html:
##########
@@ -41,49 +41,45 @@
chart = echarts.init(document.getElementById("main"), null, {
// renderer: 'svg'
});
-
var data = [
{
name: "Parent",
- value: 2,
- // this does not work for sunburst, only for pie
- itemStyle: {
- decal: { symbol: "arrow", color: "green" },
- },
children: [
{
name: "Base decal",
value: 1,
- itemStyle: {
- decal: { symbol: "circle" },
- },
+ itemStyle: { decal: { symbol: "none" } },
},
{
name: "Changed decal",
value: 1,
itemStyle: {
- decal: { symbol: "rect" },
+ decal: {
+ symbol: "rect",
+ },
},
},
],
},
];
option = {
- // this overwrites all in sunburst
aria: {
enabled: true,
decal: {
show: true,
- decals: { symbol: "diamond" },
+ decals: {
+ symbol: "circle",
+ },
},
},
series: {
type: "sunburst",
- // type: 'pie',
data: data,
radius: [0, "90%"],
- label: { rotate: "radial" },
- itemStyle: { decal: { symbol: "arrow", color: "red" } },
+ label: {
+ rotate: "radial",
+ },
+ // itemStyle: { decal: { symbol: "arrow" } },
Review Comment:
Please add another test case:
```ts
var data = [
{
name: 'Grandpa',
children: [
{
name: 'Uncle Leo',
value: 15,
children: [
{
name: 'Cousin Jack',
value: 2
},
{
name: 'Cousin Mary',
value: 5,
children: [
{
name: 'Jackson',
value: 2
}
]
},
{
name: 'Cousin Ben',
value: 4
}
]
},
{
name: 'Aunt Jane',
children: [
{
name: 'Cousin Kate',
value: 4
}
]
},
{
name: 'Father',
value: 10,
children: [
{
name: 'Me',
value: 5
},
{
name: 'Brother Peter',
value: 1
}
]
}
]
},
{
name: 'Mike',
children: [
{
name: 'Uncle Dan',
children: [
{
name: 'Cousin Lucy',
value: 3
},
{
name: 'Cousin Luck',
value: 4,
children: [
{
name: 'Nephew',
value: 2
}
]
}
]
}
]
},
{
name: 'Nancy',
children: [
{
name: 'Uncle Nike',
children: [
{
name: 'Cousin Betty',
value: 1
},
{
name: 'Cousin Jenny',
value: 2
}
]
}
]
}
];
option = {
aria: {
enabled: true,
decal: {
show: true
},
},
series: {
type: "sunburst",
data: data,
radius: [0, "90%"],
label: {
show: false
}
},
};
```
##########
src/visual/aria.ts:
##########
@@ -82,15 +82,10 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
if (ecModel.isSeriesFiltered(seriesModel)) {
return;
}
- if (zrUtil.isFunction(seriesModel.enableAriaDecal)) {
- // Let series define how to use decal palette on data
- seriesModel.enableAriaDecal();
- return;
- }
const data = seriesModel.getData();
- if (!seriesModel.isColorBySeries()) {
+ if (seriesModel.isColorBySeries()) {
Review Comment:
This is not correct because this will break decal for other series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1588701463
@Aman1919 Please check [this demo](https://echarts.apache.org/examples/zh/editor.html?c=sunburst-simple). The colors are correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1443569645
added a test case for the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1509234483
I did changes after that result is looking like this
but it giving default backgroundcolor blue . I checked in pie and treemap they were also giving default blue . is this will be correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1506551119
@Aman1919 By default, the color should act like this. Color relating to value is only used when visualMap is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1525669757
i did changes and result is looking like this . is this will be correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18285: fix decal in aria
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1506207239
@Aman1919 Yes, in the above image, if two items have the same color, they should have the same decal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Aman1919 commented on pull request #18285: fix decal in aria
Posted by "Aman1919 (via GitHub)" <gi...@apache.org>.
Aman1919 commented on PR #18285:
URL: https://github.com/apache/echarts/pull/18285#issuecomment-1504970849
After fixing result was looking like this
mike, nancy and grandpa decal are working
do you mean their children should also have their decal ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org