You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/25 06:57:32 UTC
[GitHub] [skywalking] songzhendong opened a new pull request #4568: Update
How-to-build.md
songzhendong opened a new pull request #4568: Update How-to-build.md
URL: https://github.com/apache/skywalking/pull/4568
Modify Eclipse and IDEA steps
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4568: Update
How-to-build.md
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4568: Update How-to-build.md
URL: https://github.com/apache/skywalking/pull/4568#issuecomment-603687878
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=h1) Report
> Merging [#4568](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/72f46f749989a08089325fde3149a0a67fed9abd&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4568 +/- ##
=======================================
Coverage 25.86% 25.86%
=======================================
Files 1246 1246
Lines 28975 28975
Branches 3974 3974
=======================================
Hits 7495 7495
Misses 20786 20786
Partials 694 694
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=footer). Last update [72f46f7...e024d8c](https://codecov.io/gh/apache/skywalking/pull/4568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4568:
Update How-to-build.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4568: Update How-to-build.md
URL: https://github.com/apache/skywalking/pull/4568#discussion_r397691096
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -89,7 +89,7 @@ Refer to [Build docker image](../../../docker) for more details.
* `antlr4` folder in **oap-server/oal-grammar/target/generated-sources**
## Setup your Eclipse IDE
-**NOTICE**: If you clone the codes from GitHub, please make sure that you had finished step 1 to 7 in section **[Build from GitHub](#build-from-github)**, if you download the source codes from the official website of SkyWalking, please make sure that you had followed the steps in section **[Build from Apache source code release](#build-from-apache-source-code-release)**.
+**NOTICE**: If you clone the codes from GitHub, please make sure that you had finished step 1 to 3 in section **[Build from GitHub](#build-from-github)**, if you download the source codes from the official website of SkyWalking, please make sure that you had followed the steps in section **[Build from Apache source code release](#build-from-apache-source-code-release)**.
Review comment:
From my reading, the Eclipse still has 8 steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4568: Update
How-to-build.md
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4568: Update How-to-build.md
URL: https://github.com/apache/skywalking/pull/4568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4568:
Update How-to-build.md
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4568: Update How-to-build.md
URL: https://github.com/apache/skywalking/pull/4568#discussion_r397691096
##########
File path: docs/en/guides/How-to-build.md
##########
@@ -89,7 +89,7 @@ Refer to [Build docker image](../../../docker) for more details.
* `antlr4` folder in **oap-server/oal-grammar/target/generated-sources**
## Setup your Eclipse IDE
-**NOTICE**: If you clone the codes from GitHub, please make sure that you had finished step 1 to 7 in section **[Build from GitHub](#build-from-github)**, if you download the source codes from the official website of SkyWalking, please make sure that you had followed the steps in section **[Build from Apache source code release](#build-from-apache-source-code-release)**.
+**NOTICE**: If you clone the codes from GitHub, please make sure that you had finished step 1 to 3 in section **[Build from GitHub](#build-from-github)**, if you download the source codes from the official website of SkyWalking, please make sure that you had followed the steps in section **[Build from Apache source code release](#build-from-apache-source-code-release)**.
Review comment:
From my reading, the Eclipse still has 8 steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services