You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/06/11 20:36:21 UTC

[GitHub] [lucene-solr] ErickErickson commented on pull request #1563: LUCENE-9394: fix and suppress warnings

ErickErickson commented on pull request #1563:
URL: https://github.com/apache/lucene-solr/pull/1563#issuecomment-642915566


   speaking from experience, when dealing with this many changes in a big wodge, it’s _very easy_ to have some things slip through ;)
   
   > On Jun 11, 2020, at 3:34 PM, Michael Sokolov <no...@github.com> wrote:
   > 
   > 
   > Thanks for the comments, @madrob, I posted a new PR addressing them. I'm not sure how I missed all that unused code in RandomizedShapeTestCase - it's pretty bare now!
   > 
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org