You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2024/12/27 16:48:21 UTC

[PR] Remove aws v1 from infrastructure [beam]

damccorm opened a new pull request, #33455:
URL: https://github.com/apache/beam/pull/33455

   Part of https://github.com/apache/beam/issues/33430 to remove AWS v1 IOs entirely. This removes the v1 precommits and removes them from our infra used for load testing
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove aws v1 from infrastructure [beam]

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.

ahmedabu98 commented on code in PR #33455:
URL: https://github.com/apache/beam/pull/33455#discussion_r1899515877


##########
sdks/java/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java:
##########
@@ -180,17 +183,27 @@ private static void writeToKafka(PCollection<KV<byte[], byte[]>> collection) {
   }
 
   private static void writeToKinesis(PCollection<KV<byte[], byte[]>> collection) {
+    AwsBasicCredentials creds =
+        AwsBasicCredentials.create(options.getKinesisAwsKey(), options.getKinesisAwsSecret());
+    StaticCredentialsProvider provider = StaticCredentialsProvider.create(creds);
     collection
         .apply("Map to byte array for Kinesis", MapElements.via(new MapKVToByteArray()))
         .apply(
             "Write to Kinesis",
-            KinesisIO.write()
+            KinesisIO.<byte[]>write()
                 .withStreamName(options.getKinesisStreamName())
-                .withPartitionKey(options.getKinesisPartitionKey())
-                .withAWSClientsProvider(
-                    options.getKinesisAwsKey(),
-                    options.getKinesisAwsSecret(),
-                    Regions.fromName(options.getKinesisAwsRegion())));
+                .withPartitioner(p -> options.getKinesisPartitionKey())
+                // .withPartitionKey(options.getKinesisPartitionKey())
+                // .withAWSClientsProvider(
+                //     options.getKinesisAwsKey(),
+                //     options.getKinesisAwsSecret(),
+                //     Regions.fromName(options.getKinesisAwsRegion())
+                // ));

Review Comment:
   nit: cleanup



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org