You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/01/25 07:04:13 UTC
Review Request 42707: LENS-927 : Fix intermittent test failure due to
alias look up in JoinTree
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-927
https://issues.apache.org/jira/browse/LENS-927
Repository: lens
Description
-------
The failure is because the JoinTree construction is picking the alias from query, which is not required. Removing the same, fixed the failure.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java acc9d5c
lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 197847c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d7707a9
Diff: https://reviews.apache.org/r/42707/diff/
Testing
-------
All cube tests passed. Running full suite.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 42707: LENS-927 : Fix intermittent test failure
due to alias look up in JoinTree
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Jan. 25, 2016, 6:06 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java, line 128
> > <https://reviews.apache.org/r/42707/diff/1/?file=1219151#file1219151line128>
> >
> > The comment is not valid now?
Yes. The Dimensions being destinations in auto join resolution has been removed in LENS-735
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/#review116044
-----------------------------------------------------------
On Jan. 25, 2016, 6:04 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42707/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 6:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-927
> https://issues.apache.org/jira/browse/LENS-927
>
>
> Repository: lens
>
>
> Description
> -------
>
> The failure is because the JoinTree construction is picking the alias from query, which is not required. Removing the same, fixed the failure.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java acc9d5c
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 197847c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d7707a9
>
> Diff: https://reviews.apache.org/r/42707/diff/
>
>
> Testing
> -------
>
> All cube tests passed. Running full suite.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42707: LENS-927 : Fix intermittent test failure
due to alias look up in JoinTree
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/#review116044
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java
<https://reviews.apache.org/r/42707/#comment177058>
The comment is not valid now?
- Rajat Khandelwal
On Jan. 25, 2016, 11:34 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42707/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 11:34 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-927
> https://issues.apache.org/jira/browse/LENS-927
>
>
> Repository: lens
>
>
> Description
> -------
>
> The failure is because the JoinTree construction is picking the alias from query, which is not required. Removing the same, fixed the failure.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java acc9d5c
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 197847c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d7707a9
>
> Diff: https://reviews.apache.org/r/42707/diff/
>
>
> Testing
> -------
>
> All cube tests passed. Running full suite.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42707: LENS-927 : Fix intermittent test failure
due to alias look up in JoinTree
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/#review116067
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Jan. 25, 2016, 12:40 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42707/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 12:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-927
> https://issues.apache.org/jira/browse/LENS-927
>
>
> Repository: lens
>
>
> Description
> -------
>
> The failure is because the JoinTree construction is picking the alias from query, which is not required. Removing the same, fixed the failure.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java acc9d5c
> lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 197847c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d7707a9
>
> Diff: https://reviews.apache.org/r/42707/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.606s]
> [INFO] Lens .............................................. SUCCESS [2.790s]
> [INFO] Lens API .......................................... SUCCESS [19.792s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.371s]
> [INFO] Lens Cube ......................................... SUCCESS [10:46.793s]
> [INFO] Lens DB storage ................................... SUCCESS [15.367s]
> [INFO] Lens Query Library ................................ SUCCESS [13.164s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:26.978s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.747s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.980s]
> [INFO] Lens Server ....................................... SUCCESS [9:31.080s]
> [INFO] Lens client ....................................... SUCCESS [35.995s]
> [INFO] Lens CLI .......................................... SUCCESS [52.525s]
> [INFO] Lens Examples ..................................... SUCCESS [7.382s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.855s]
> [INFO] Lens Distribution ................................. SUCCESS [9.452s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:12.527s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.021s]
> [INFO] Lens Regression ................................... SUCCESS [10.385s]
> [INFO] Lens UI ........................................... SUCCESS [29.723s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 28:27.302s
> [INFO] Finished at: Mon Jan 25 07:05:45 UTC 2016
> [INFO] Final Memory: 154M/2223M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 42707: LENS-927 : Fix intermittent test failure
due to alias look up in JoinTree
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42707/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 7:10 a.m.)
Review request for lens.
Changes
-------
Fixed checkstyle issue
Bugs: LENS-927
https://issues.apache.org/jira/browse/LENS-927
Repository: lens
Description
-------
The failure is because the JoinTree construction is picking the alias from query, which is not required. Removing the same, fixed the failure.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java acc9d5c
lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 197847c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java d7707a9
Diff: https://reviews.apache.org/r/42707/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.606s]
[INFO] Lens .............................................. SUCCESS [2.790s]
[INFO] Lens API .......................................... SUCCESS [19.792s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.371s]
[INFO] Lens Cube ......................................... SUCCESS [10:46.793s]
[INFO] Lens DB storage ................................... SUCCESS [15.367s]
[INFO] Lens Query Library ................................ SUCCESS [13.164s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:26.978s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.747s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.980s]
[INFO] Lens Server ....................................... SUCCESS [9:31.080s]
[INFO] Lens client ....................................... SUCCESS [35.995s]
[INFO] Lens CLI .......................................... SUCCESS [52.525s]
[INFO] Lens Examples ..................................... SUCCESS [7.382s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.855s]
[INFO] Lens Distribution ................................. SUCCESS [9.452s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:12.527s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.021s]
[INFO] Lens Regression ................................... SUCCESS [10.385s]
[INFO] Lens UI ........................................... SUCCESS [29.723s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28:27.302s
[INFO] Finished at: Mon Jan 25 07:05:45 UTC 2016
[INFO] Final Memory: 154M/2223M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu