You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "JiaqiWang18 (via GitHub)" <gi...@apache.org> on 2025/07/21 05:55:07 UTC
[PR] [SPARK-52853][SDP] Prevent imperative conf set in declarative pipelines [spark]
JiaqiWang18 opened a new pull request, #51590:
URL: https://github.com/apache/spark/pull/51590
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on PR #51590:
URL: https://github.com/apache/spark/pull/51590#issuecomment-3099351811
@sryza @anishm-db Ready for review. Re-scoped PR to only block imperative python methods on the client-side via a context manager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2226875041
##########
python/pyspark/errors/error-conditions.json:
##########
@@ -1002,6 +1002,73 @@
"Cannot start a remote Spark session because there is a regular Spark session already running."
]
},
+ "SESSION_MUTATION_IN_DECLARATIVE_PIPELINE": {
+ "message": [
+ "Session mutation <method> is not allowed in declarative pipelines."
+ ],
+ "sub_class": {
+ "RUNTIME_CONF_SET": {
Review Comment:
Nitpick: should the `SET` be on the other side of `RUNTIME_CONF` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative conf set in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on PR #51590:
URL: https://github.com/apache/spark/pull/51590#issuecomment-3097921276
@sryza @anishm-db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2226953727
##########
python/pyspark/errors/error-conditions.json:
##########
@@ -1002,6 +1002,73 @@
"Cannot start a remote Spark session because there is a regular Spark session already running."
]
},
+ "SESSION_MUTATION_IN_DECLARATIVE_PIPELINE": {
+ "message": [
+ "Session mutation <method> is not allowed in declarative pipelines."
+ ],
+ "sub_class": {
+ "RUNTIME_CONF_SET": {
Review Comment:
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2226815672
##########
python/pyspark/pipelines/block_imperative_construct.py:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+from typing import Generator, NoReturn, List, Callable
+
+from pyspark.errors import PySparkException
+from pyspark.sql.connect.catalog import Catalog
+from pyspark.sql.connect.conf import RuntimeConf
+from pyspark.sql.connect.dataframe import DataFrame
+from pyspark.sql.connect.udf import UDFRegistration
+
+# pyspark methods that should be blocked from executing in python pipeline definition files
+BLOCKED_METHODS: List = [
+ {
+ "class": RuntimeConf,
+ "method": "set",
+ "suggestion": "Instead set configuration via the pipeline spec "
+ "or use the 'spark_conf' argument in various decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentCatalog",
+ "suggestion": "Instead set catalog via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentDatabase",
+ "suggestion": "Instead set database via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "dropTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": Catalog,
+ "method": "dropGlobalTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": DataFrame,
+ "method": "createTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "register",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaFunction",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaUDAF",
+ "suggestion": "",
+ },
+]
+
+
+def _create_blocked_method(error_method_name: str, suggestion: str) -> Callable:
+ def blocked_method(*args: object, **kwargs: object) -> NoReturn:
+ raise PySparkException(
+ errorClass="IMPERATIVE_CONSTRUCT_IN_DECLARATIVE_PIPELINE",
+ messageParameters={
+ "method": error_method_name,
+ "suggestion": suggestion,
+ },
+ )
+
+ return blocked_method
+
+
+@contextmanager
+def block_imperative_construct() -> Generator[None, None, None]:
Review Comment:
renamed to `block_session_mutations` to be more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative conf set in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on PR #51590:
URL: https://github.com/apache/spark/pull/51590#issuecomment-3098433302
addressing discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "JiaqiWang18 (via GitHub)" <gi...@apache.org>.
JiaqiWang18 commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2226818286
##########
python/pyspark/pipelines/block_imperative_construct.py:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+from typing import Generator, NoReturn, List, Callable
+
+from pyspark.errors import PySparkException
+from pyspark.sql.connect.catalog import Catalog
+from pyspark.sql.connect.conf import RuntimeConf
+from pyspark.sql.connect.dataframe import DataFrame
+from pyspark.sql.connect.udf import UDFRegistration
+
+# pyspark methods that should be blocked from executing in python pipeline definition files
+BLOCKED_METHODS: List = [
+ {
+ "class": RuntimeConf,
+ "method": "set",
+ "suggestion": "Instead set configuration via the pipeline spec "
Review Comment:
Make sense, added sub classes for each method in `error-conditons.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza closed pull request #51590: [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines
URL: https://github.com/apache/spark/pull/51590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "sryza (via GitHub)" <gi...@apache.org>.
sryza commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2226019454
##########
python/pyspark/pipelines/block_imperative_construct.py:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+from typing import Generator, NoReturn, List, Callable
+
+from pyspark.errors import PySparkException
+from pyspark.sql.connect.catalog import Catalog
+from pyspark.sql.connect.conf import RuntimeConf
+from pyspark.sql.connect.dataframe import DataFrame
+from pyspark.sql.connect.udf import UDFRegistration
+
+# pyspark methods that should be blocked from executing in python pipeline definition files
+BLOCKED_METHODS: List = [
+ {
+ "class": RuntimeConf,
+ "method": "set",
+ "suggestion": "Instead set configuration via the pipeline spec "
+ "or use the 'spark_conf' argument in various decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentCatalog",
+ "suggestion": "Instead set catalog via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentDatabase",
+ "suggestion": "Instead set database via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "dropTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": Catalog,
+ "method": "dropGlobalTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": DataFrame,
+ "method": "createTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "register",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaFunction",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaUDAF",
+ "suggestion": "",
+ },
+]
+
+
+def _create_blocked_method(error_method_name: str, suggestion: str) -> Callable:
+ def blocked_method(*args: object, **kwargs: object) -> NoReturn:
+ raise PySparkException(
+ errorClass="IMPERATIVE_CONSTRUCT_IN_DECLARATIVE_PIPELINE",
+ messageParameters={
+ "method": error_method_name,
+ "suggestion": suggestion,
+ },
+ )
+
+ return blocked_method
+
+
+@contextmanager
+def block_imperative_construct() -> Generator[None, None, None]:
Review Comment:
```suggestion
def block_imperative_constructs() -> Generator[None, None, None]:
```
##########
python/pyspark/errors/error-conditions.json:
##########
@@ -363,6 +363,12 @@
"Function `<func_name>` should return Column, got <return_type>."
]
},
+ "IMPERATIVE_CONSTRUCT_IN_DECLARATIVE_PIPELINE": {
+ "message": [
+ "Imperative construct <method> is not allowed in declarative pipelines.",
Review Comment:
People can have different ideas of what "imperative" means, so I wonder if we should be more specific here. E.g. "Changing Spark session state is not allowed in declarative pipelines" or "Imperative constructs like changing Spark session state are not allowed in declarative pipelines".
##########
python/pyspark/pipelines/block_imperative_construct.py:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+from typing import Generator, NoReturn, List, Callable
+
+from pyspark.errors import PySparkException
+from pyspark.sql.connect.catalog import Catalog
+from pyspark.sql.connect.conf import RuntimeConf
+from pyspark.sql.connect.dataframe import DataFrame
+from pyspark.sql.connect.udf import UDFRegistration
+
+# pyspark methods that should be blocked from executing in python pipeline definition files
+BLOCKED_METHODS: List = [
+ {
+ "class": RuntimeConf,
+ "method": "set",
+ "suggestion": "Instead set configuration via the pipeline spec "
+ "or use the 'spark_conf' argument in various decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentCatalog",
+ "suggestion": "Instead set catalog via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "setCurrentDatabase",
+ "suggestion": "Instead set database via the pipeline spec "
+ "or the 'name' argument on the dataset decorators",
+ },
+ {
+ "class": Catalog,
+ "method": "dropTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": Catalog,
+ "method": "dropGlobalTempView",
+ "suggestion": "Instead remove the temporary view definition directly",
+ },
+ {
+ "class": DataFrame,
+ "method": "createTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": DataFrame,
+ "method": "createOrReplaceGlobalTempView",
+ "suggestion": "Instead use the @temporary_view decorator to define temporary views",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "register",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaFunction",
+ "suggestion": "",
+ },
+ {
+ "class": UDFRegistration,
+ "method": "registerJavaUDAF",
+ "suggestion": "",
+ },
+]
+
+
+def _create_blocked_method(error_method_name: str, suggestion: str) -> Callable:
+ def blocked_method(*args: object, **kwargs: object) -> NoReturn:
+ raise PySparkException(
+ errorClass="IMPERATIVE_CONSTRUCT_IN_DECLARATIVE_PIPELINE",
+ messageParameters={
+ "method": error_method_name,
+ "suggestion": suggestion,
+ },
+ )
+
+ return blocked_method
+
+
+@contextmanager
+def block_imperative_construct() -> Generator[None, None, None]:
+ """
+ Context manager that blocks imperative constructs found in a pipeline python definition file
+ Blocks:
+ - imperative config set via: spark.conf.set("k", "v")
Review Comment:
It will be easy for this list to get out of sync with BLOCKED_METHODS if we add more. I think better to mention BLOCKED_METHODS here than to try to enumerate all its contents here.
##########
python/pyspark/pipelines/block_imperative_construct.py:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+from contextlib import contextmanager
+from typing import Generator, NoReturn, List, Callable
+
+from pyspark.errors import PySparkException
+from pyspark.sql.connect.catalog import Catalog
+from pyspark.sql.connect.conf import RuntimeConf
+from pyspark.sql.connect.dataframe import DataFrame
+from pyspark.sql.connect.udf import UDFRegistration
+
+# pyspark methods that should be blocked from executing in python pipeline definition files
+BLOCKED_METHODS: List = [
+ {
+ "class": RuntimeConf,
+ "method": "set",
+ "suggestion": "Instead set configuration via the pipeline spec "
Review Comment:
It would be better to have this text inside of the error-conditions.json – that way it's in a central place that can be internationalized more easily. Thoughts on having a sub-error code for each of these? E.g. `SET_CURRENT_CATALOG`?
##########
python/pyspark/errors/error-conditions.json:
##########
@@ -363,6 +363,12 @@
"Function `<func_name>` should return Column, got <return_type>."
]
},
+ "IMPERATIVE_CONSTRUCT_IN_DECLARATIVE_PIPELINE": {
Review Comment:
```suggestion
"SESSION_MUTATION_IN_DECLARATIVE_PIPELINE": {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52853][SDP] Prevent imperative PySpark methods in declarative pipelines [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #51590:
URL: https://github.com/apache/spark/pull/51590#discussion_r2220543673
##########
python/pyspark/pipelines/tests/test_block_imperative_construct.py:
##########
@@ -0,0 +1,255 @@
+#
Review Comment:
Should be added into `dev/sparktestsupport/modules.py` so the tests are actually triggred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org