You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Lon F. Binder (JIRA)" <ji...@apache.org> on 2011/04/04 20:29:05 UTC
[jira] [Created] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
--------------------------------------------------------------------------
Key: OFBIZ-4242
URL: https://issues.apache.org/jira/browse/OFBIZ-4242
Project: OFBiz
Issue Type: Bug
Components: ALL APPLICATIONS
Affects Versions: Release 09.04
Reporter: Lon F. Binder
Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022715#comment-13022715 ]
Jacques Le Roux commented on OFBIZ-4242:
----------------------------------------
Thanks Lon, it gives at least an idea about it
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-4242:
--------------------------------------
Assignee: Jacques Le Roux
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Lon F. Binder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022712#comment-13022712 ]
Lon F. Binder commented on OFBIZ-4242:
--------------------------------------
We did some preliminaries, but the changes were co-mingled with a number of others, so I don't have clean profile data.
One thing I can say is that the system startup is substantially faster. Another benefit is that when the cluster is out of sync, which we've seen numerous times after a crash due to extremely high load, the re-synchronization is much faster because instead of waiting 60+ seconds for each component, it is only 60+ for the selected components (in our case 4 vs. ~30).
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4242.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Lon,
I have added by hand a slightly modified version of your patch in trunk at revision: 1326064
I notably replaced some tabs, reformatted, added a comment about <distributable/> in the *-containers.file
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: cluster, clustering, tomcat
> Fix For: SVN trunk
>
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4242.
----------------------------------
Resolution: Not A Problem
Without an answer, I assume it's not a problem
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084202#comment-13084202 ]
Jacques Le Roux commented on OFBIZ-4242:
----------------------------------------
Lon,
First thing, your patch is done for 9.04 we don't apply patches on releases but bug. This is not a bug but an improvement. COuld you please redo your patch against trunk?
Also there are tabs in your patch, please follow https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices closely.
You duplicated the JavaDoc for containsString(final String fileName, from public static boolean containsString(Reader reader, final String searchString) w/out changing some infos
Thanks
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Lon F. Binder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084079#comment-13084079 ]
Lon F. Binder commented on OFBIZ-4242:
--------------------------------------
Jacques, sorry I must have missed the original question. Distributing components adds additional load to the cluster manager and the network. There are various components that don't need to distribute, such as all the administrative tools (at least for our organization). Another example are service-oriented components, which we don't want to distribute.
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-4242:
-----------------------------------
Priority: Minor (was: Major)
Affects Version/s: (was: Release 09.04)
SVN trunk
Issue Type: Improvement (was: Bug)
Changes from bug to improvement, major to minor, R09.04 to trunk.
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
> Affects Versions: SVN trunk
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Lon F. Binder (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lon F. Binder updated OFBIZ-4242:
---------------------------------
Attachment: ofbiz-4242-patch.txt
This file adds a feature to FileUtil to support the primary logic change in the CatalinaContainer.java to check for the {{<distributable/>}} node in applications' {{web.xml}} file and to respect it appropriately.
This patch is overly simplistic and only searches for the node text. The proper fix would be to parse the {{web.xml}} as XML and ensure the valid node is there. Then (probably) to set this value in the WebappInfo object and track it there.
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030359#comment-13030359 ]
Jacques Le Roux commented on OFBIZ-4242:
----------------------------------------
Lon,
One thing I don't get though: if you don't need these components why don't you simply comment them out in the component-load.xml files. Or do you need them but not shared by all the machines and then why (seems weird to me)?
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022709#comment-13022709 ]
Jacques Le Roux commented on OFBIZ-4242:
----------------------------------------
Hi Lon,
Did you already made some measures with a profiler, to see how it impacts performance?
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (OFBIZ-4242) CatalinaContainer Doesn't Respect
Node for web.xml files.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reopened OFBIZ-4242:
------------------------------------
Hi Lon,
This makes sense indeed, I will have a look...
> CatalinaContainer Doesn't Respect <distributable/> Node for web.xml files.
> --------------------------------------------------------------------------
>
> Key: OFBIZ-4242
> URL: https://issues.apache.org/jira/browse/OFBIZ-4242
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
> Affects Versions: Release 09.04
> Reporter: Lon F. Binder
> Assignee: Jacques Le Roux
> Labels: cluster, clustering, tomcat
> Attachments: ofbiz-4242-patch.txt
>
>
> Per the servlet specification, the {{web.xml}} file should allow an optional {{<distributable/>}} node to indicate that the application is clusterable. Currently, OFBiz does not respect this setting and assumes all applications should be distributed if any cluster configuration is provided in the {{ofbiz-containers.xml}} file. As a result, if, for example, the {{DeltaManager}} is enable, all applications attempt to cluster and communicate via {{DeltaManager}}.
> The expected and proper functionality is to check the individual application's web.xml file for the {{<distributable/>}} node and only use the {{DeltaManager}} if found; otherwise the {{StandardManager}} should be used for sessions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira