[GitHub] [pulsar] merlimat commented on a diff in pull request #16399: [fix][broker] OpReadEntry is not recycled in some corner cases

[GitBox <gi...@apache.org>]

merlimat commented on code in PR #16399:
URL: https://github.com/apache/pulsar/pull/16399#discussion_r914248637


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -48,6 +53,9 @@ class OpReadEntry implements ReadEntriesCallback {
     public static OpReadEntry create(ManagedCursorImpl cursor, PositionImpl readPositionRef, int count,
             ReadEntriesCallback callback, Object ctx, PositionImpl maxPosition) {
         OpReadEntry op = RECYCLER.get();
+        if (createCount != null) {

Review Comment:
   This will introduce a `volatile` read in the prod code which is not free. I'd avoid it if the purpose is for testing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org