[jira] [Commented] (OAK-4712) Publish S3DataStore stats in JMX MBean

["Amit Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457464#comment-15457464 ] 

Amit Jain commented on OAK-4712:
--------------------------------

[~mattvryan] I had a quick look. A few comments
* Instead of introducing a new interface {{NodeIdMapper}} and have separate implementations for each NodeStoreService, we could inject the NodeStore implementations into the JMX bean itself and then implement the path to id mapping there.

* Also, for removing the length encoding in the blobs rather than working with the implementations details we could use the {{BlobId}} class in the {{DataStoreBlobStore}} to give back the id stripped off the length encoding.

* An important issue that came to my mind was that the actual node paths may not directly contain the binary property. As an example if the node type is nt:file then the binary property is in {{jcr:content/jcr:data}} property under the actual node - {{/content/a/b.jpg}} and similarly it may be different for other node types e.g. for some application dam:Asset. So, we should get a clarity on what the expectations are wrt to the input.
** It could either be that we are given the direct node path under which the property resides like  {{/content/a/b.jpg/jcr:content}}
** Or we are given just the user friendly path  {{/content/a/b.jpg}} and we recursively (maybe limited to a depth) go and find binaries. This way we could find multiple binaries also.

> Publish S3DataStore stats in JMX MBean
> --------------------------------------
>
>                 Key: OAK-4712
>                 URL: https://issues.apache.org/jira/browse/OAK-4712
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: blob
>            Reporter: Matt Ryan
>         Attachments: OAK-4712.2.diff, OAK-4712.3.diff
>
>
> This feature is to publish statistics about the S3DataStore via a JMX MBean.  There are two statistics suggested:
> * Indicate the number of files actively being synchronized from the local cache into S3
> * Given a path to a local file, indicate whether synchronization of file into S3 has completed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)