[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1377: MINIFICPP-1865 Integrate performance clang-tidy checks in CI

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1377:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r947942230


##########
libminifi/src/c2/C2Agent.cpp:
##########
@@ -739,7 +739,7 @@ utils::TaskRescheduleInfo C2Agent::produce() {
         std::make_move_iterator(payload_batch.end()),
         [&] (C2Payload&& payload) {
           try {
-            C2Payload && response = protocol_.load()->consumePayload(std::move(payload));
+            C2Payload && response = protocol_.load()->consumePayload(payload);

Review Comment:
   Updated in 7d86623adbe9d1cf018a62e72536bce62cd4332d



##########
libminifi/test/unit/ExpectedTest.cpp:
##########
@@ -52,7 +52,7 @@ TEST_CASE("expected map", "[expected][map]") {
 
   {
     const nonstd::expected<int, int> e = 21;
-    auto ret = std::move(e) | utils::map(mul2);
+    auto ret = e | utils::map(mul2);

Review Comment:
   Good catch, updated in 7d86623adbe9d1cf018a62e72536bce62cd4332d



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org