[GitHub] [spark] squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #24898: [SPARK-22340][PYTHON] Add a mode to pin Python thread into JVM's
URL: https://github.com/apache/spark/pull/24898#discussion_r338661570
 
 

 ##########
 File path: python/pyspark/context.py
 ##########
 @@ -1010,13 +1010,42 @@ def setJobGroup(self, groupId, description, interruptOnCancel=False):
         ensure that the tasks are actually stopped in a timely manner, but is off by default due
         to HDFS-1208, where HDFS may respond to Thread.interrupt() by marking nodes as dead.
         """
+        warnings.warn(
 
 Review comment:
   Unless you feel strongly about it, I'd rather have a hard failure if you try to call this, when you are not in pinned mode.
   
   Did you intentionally want a warning even if you are in pinned mode, just to include the info about inherited threads?  I think warning is too strong in that case, how about info?  Also the docstring should be updated to include the caveat on inherited threads

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org