You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by BryanCutler <gi...@git.apache.org> on 2015/09/04 01:43:10 UTC
[GitHub] spark pull request: [SPARK-6931] [PYSPARK] Cast Python time float ...
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/8593
[SPARK-6931] [PYSPARK] Cast Python time float values to int before serialization
Python time values return a floating point value, need to cast to integer before serialize with struct.pack('!q', value)
https://issues.apache.org/jira/browse/SPARK-6931
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BryanCutler/spark py-write_long-backport-6931-1.3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8593
----
commit 20cfeafd8557be55473b8091194704aec2ea3ba6
Author: Bryan Cutler <bj...@us.ibm.com>
Date: 2015-09-03T23:38:45Z
[SPARK-6931] Correctly cast Python time float values to int before serialization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6931] [PYSPARK] Cast Python time float ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8593#issuecomment-139334476
#8594 is merged into 1.3 branch, can you close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6931] [PYSPARK] Cast Python time float ...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler closed the pull request at:
https://github.com/apache/spark/pull/8593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6931] [PYSPARK] Cast Python time float ...
Posted by BryanCutler <gi...@git.apache.org>.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/8593#issuecomment-139335861
sure, thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6931] [PYSPARK] Cast Python time float ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8593#issuecomment-137603254
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org