You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/30 06:14:39 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

mattisonchao opened a new pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164


   ### Motivation
   
   Use Awaitility to instead of Thread sleep
   
   ### Modifications
   
   - Use Awaitility to instead of Thread sleep


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao removed a comment on pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164#issuecomment-871131192


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164#discussion_r662001748



##########
File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/client/cli/PulsarClientToolTest.java
##########
@@ -207,7 +186,7 @@ public void testDurableSubscribe() throws Exception {
         Assert.assertFalse(future.isCompletedExceptionally());
         future.get();
         //wait for close
-        Thread.sleep(2000);
+        Awaitility.waitAtMost(Duration.ofDays(2000));

Review comment:
       #11176 FIxed this mistake




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on a change in pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164#discussion_r661976622



##########
File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/client/cli/PulsarClientToolTest.java
##########
@@ -207,7 +186,7 @@ public void testDurableSubscribe() throws Exception {
         Assert.assertFalse(future.isCompletedExceptionally());
         future.get();
         //wait for close
-        Thread.sleep(2000);
+        Awaitility.waitAtMost(Duration.ofDays(2000));

Review comment:
       Was this change intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on a change in pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164#discussion_r661977761



##########
File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/client/cli/PulsarClientToolTest.java
##########
@@ -207,7 +186,7 @@ public void testDurableSubscribe() throws Exception {
         Assert.assertFalse(future.isCompletedExceptionally());
         future.get();
         //wait for close
-        Thread.sleep(2000);
+        Awaitility.waitAtMost(Duration.ofDays(2000));

Review comment:
       I'm so sorry, This is my mistake, I will fix it ASAP. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #11164: [ Tests ] Use Awaitility to instead of Thread sleep

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #11164:
URL: https://github.com/apache/pulsar/pull/11164#issuecomment-871131192


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org