You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/11/04 17:54:19 UTC
[GitHub] [druid] ektravel opened a new pull request, #13316: Update Metrics doc
ektravel opened a new pull request, #13316:
URL: https://github.com/apache/druid/pull/13316
### Description
Updated Metrics doc as follows:
- fixed the formatting for dimensions (code font)
- removed unnecessary punctuation
This PR has:
- [x] been self-reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ektravel commented on a diff in pull request #13316: Update Metrics doc
Posted by GitBox <gi...@apache.org>.
ektravel commented on code in PR #13316:
URL: https://github.com/apache/druid/pull/13316#discussion_r1015697703
##########
docs/operations/metrics.md:
##########
@@ -118,53 +118,52 @@ Metrics may have additional dimensions beyond those listed above.
Review Comment:
@techdocsmith I fixed the formatting for the Cache table and resolved merge conflicts. This PR is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a diff in pull request #13316: Update Metrics doc
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on code in PR #13316:
URL: https://github.com/apache/druid/pull/13316#discussion_r1014374393
##########
docs/operations/metrics.md:
##########
@@ -118,53 +118,52 @@ Metrics may have additional dimensions beyond those listed above.
Review Comment:
In line 115 & 116, there should only be one `|` before `N/A`. It's currently making 4 columns and breaking the table. Unless there is a missing `Dimensions` header. for the empty column. not sure. It looks like the Dimensions column is empty for the following table lines 121 to 132. I'm not sure what the value is for having a column with all the dimension cells being empty.
##########
docs/operations/metrics.md:
##########
@@ -118,53 +118,52 @@ Metrics may have additional dimensions beyond those listed above.
Review Comment:
Also not 100% sure why this table is separate, but I don't think that was part of your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz merged pull request #13316: Update Metrics doc
Posted by GitBox <gi...@apache.org>.
kfaraz merged PR #13316:
URL: https://github.com/apache/druid/pull/13316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org