You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/06 12:04:36 UTC

Review Request 27676: Broken Config banner

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27676/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-8180
    https://issues.apache.org/jira/browse/AMBARI-8180


Repository: ambari


Description
-------

I was on a config page for a service. Then I selected another service from the left service nav. Got a broken config banner.


Diffs
-----

  ambari-web/app/controllers/main/service/info/configs.js 11002c1 
  ambari-web/app/utils/ajax/ajax.js 457e4c0 
  ambari-web/app/utils/config.js df9f7ca 
  ambari-web/test/controllers/main/service/info/config_test.js 86692e7 

Diff: https://reviews.apache.org/r/27676/diff/


Testing
-------

4920 tests complete (7 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 27676: Broken Config banner

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27676/#review60144
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Лис. 6, 2014, 11:04 до полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27676/
> -----------------------------------------------------------
> 
> (Updated Лис. 6, 2014, 11:04 до полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-8180
>     https://issues.apache.org/jira/browse/AMBARI-8180
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I was on a config page for a service. Then I selected another service from the left service nav. Got a broken config banner.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 11002c1 
>   ambari-web/app/utils/ajax/ajax.js 457e4c0 
>   ambari-web/app/utils/config.js df9f7ca 
>   ambari-web/test/controllers/main/service/info/config_test.js 86692e7 
> 
> Diff: https://reviews.apache.org/r/27676/diff/
> 
> 
> Testing
> -------
> 
> 4920 tests complete (7 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>


Re: Review Request 27676: Broken Config banner

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27676/#review60141
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Nov. 6, 2014, 11:04 a.m., Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27676/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:04 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-8180
>     https://issues.apache.org/jira/browse/AMBARI-8180
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I was on a config page for a service. Then I selected another service from the left service nav. Got a broken config banner.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js 11002c1 
>   ambari-web/app/utils/ajax/ajax.js 457e4c0 
>   ambari-web/app/utils/config.js df9f7ca 
>   ambari-web/test/controllers/main/service/info/config_test.js 86692e7 
> 
> Diff: https://reviews.apache.org/r/27676/diff/
> 
> 
> Testing
> -------
> 
> 4920 tests complete (7 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>