You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rehevkor5 <gi...@git.apache.org> on 2017/01/22 20:55:24 UTC
[GitHub] flink pull request #3189: [FLINK-5608] [webfrontend] Cancel button stays vis...
GitHub user rehevkor5 opened a pull request:
https://github.com/apache/flink/pull/3189
[FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
- Most importantly, the Cancel button has been changed to float
right, and will only wrap downward if pushed out by the job name
- Also combined the job name and job id into a single horizontal
element, reducing the overall horizontal space taken by the main
navbar components in the job view, making the main navbar components
less likely to wrap downward and be overlapped by the secondary navbar.
- Compiled code has been rebuilt
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rehevkor5/flink ui_job_cancel_button_layout_issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3189
----
commit 33e3a14ebd3d614a6e5d4eae90f5985416e0b995
Author: Shannon Carey <re...@gmail.com>
Date: 2017-01-22T20:52:43Z
[FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
- Most importantly, the Cancel button has been changed to float
right, and will only wrap downward if pushed out by the job name
- Also combined the job name and job id into a single horizontal
element, reducing the overall horizontal space taken by the main
navbar components in the job view, making the main navbar components
less likely to wrap downward and be overlapped by the secondary navbar.
- Compiled code has been rebuilt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3189
Good point. @rehevkor5 is it possible to only hide the color boxes when the browser window is very narrow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3189: [FLINK-5608] [webfrontend] Cancel button stays vis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by rehevkor5 <gi...@git.apache.org>.
Github user rehevkor5 commented on the issue:
https://github.com/apache/flink/pull/3189
@zentol I updated the commit: the overall job status count is now displayed in medium-width (but not small or below), and I move the job status count to the right of job start/end & duration.
Also, I applied the float-right fix to the "Stop" button, which I didn't notice before.
You can see that the fix isn't perfect when the job name is long, but it's still better than what it was. Screenshots from Chrome 55.0.2883.95, controlling window width in the dev tool.
1200px:
1128px (you can see the top navbar wrapping down & peeking out from behind the secondary navbar:
1020px (back to normal because left navbar is collapsed):
992px (wrapping again):
991px:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3189
How come the state of tasks is no longer shown?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3189
Thanks for the PR. I also sometimes had the bad experience while testing that the cancel button was not visible. This change definitely solves it. I tested it and it works as expected. I made some screenshots and would love some feedback from other contributors before changing this.
## Wide
Current:
This PR:
## Narrow
Current:
This PR:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3189
Thanks for addressing my comments. Looks very good now. I'm going ahead and merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...
Posted by rehevkor5 <gi...@git.apache.org>.
Github user rehevkor5 commented on the issue:
https://github.com/apache/flink/pull/3189
Thanks @uce that's helpful! Didn't think of putting screenshots in the PR.
@zentol The global job state counts didn't seem like the most important thing to show when the browser is narrow, given that this view is about a particular job. So, I added these CSS classes to it ".hidden-xs .hidden-sm .hidden-md" the behavior of which is described on http://getbootstrap.com/css/#responsive-utilities I am not sure what width @uce used for the "wide" screenshots, but it probably was less than 1200px, otherwise it would show up. I can remove the ".hidden-md" class if you want it to show up in the 992px to 1200px range, too... however it does make it more likely for the other more job-specific elements (start/end, duration) to wrap & get lost. Perhaps it would be a good idea to reorder the elements? Put start/end & duration first, and overall job stats last so that it's the first one to wrap? Let me know if you have a preference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---