[GitHub] rafaelweingartner opened a new pull request #2443: [CLOUDSTACK-9338] ACS not accounting resources of VMs with custom service offering properly

[GitBox <gi...@apache.org>]

rafaelweingartner opened a new pull request #2443:  [CLOUDSTACK-9338] ACS not accounting resources of VMs with custom service offering properly
URL: https://github.com/apache/cloudstack/pull/2443
 
 
   ## Description
   ACS accounts the resources when deploying VMs with custom service offerings. However, there are other methods (such as updateResourceCount) that do not execute the resource accounting properly, and these methods update the resource count for an account in the database. Therefore, if a user deploys VMs with custom service offerings, and later this user calls the ?updateResourceCount? method, it (the method) will only account for VMs with normal service offerings, and update this as the number of resources used by the account. This will result in a smaller number of resources to be accounted for the given account than the real used value. The problem becomes worse because if the user starts to delete these VMs, it is possible to reach negative values of resources allocated (breaking all of the resource limiting for accounts). This is a very serious attack vector for public cloud providers!
   
   ## Steps to reproduce:
   
   1. Create a new account and dedicate some resources to it
   2. Instantiate a VM using a custom service offering
   3. Check the CPU and memory resource count for the given VM (the count must be correct at this point): select * from resource_count where account_id = ?
   4. Go to the details of the account and click on ?Update resource count?
   5. Execute the SQL again (select * from resource_count where account_id = ?), and check if the resource count is correct. The value of resource count will consider only VMs deployed with normal service offering;
   6. Delete all VMs
   7. Check the resource count table again. It will reach negative values.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services