You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2015/11/19 21:52:17 UTC
svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Author: rhuijben
Date: Thu Nov 19 20:52:17 2015
New Revision: 1715269
URL: http://svn.apache.org/viewvc?rev=1715269&view=rev
Log:
* STATUS: Nominate three trivial dav fixes.
Modified:
subversion/branches/1.9.x/STATUS
Modified: subversion/branches/1.9.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x/STATUS?rev=1715269&r1=1715268&r2=1715269&view=diff
==============================================================================
--- subversion/branches/1.9.x/STATUS (original)
+++ subversion/branches/1.9.x/STATUS Thu Nov 19 20:52:17 2015
@@ -136,6 +136,13 @@ Candidate changes:
Votes:
+1: stefan2
+ * r1715224, r1715232, r1715262
+ ra_serf: Fix setting Content-Type header in 3 outgoing xml requests
+ Justification:
+ We should properly implement our wire protocol.
+ Votes:
+ +1: rhuijben
+
Veto-blocked changes:
=====================
Re: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Posted by Julian Foad <ju...@gmail.com>.
Bert Huijben wrote:
> There is currently no way how a user with released software can encounter
> this problem.
Thank you for sharing this useful background information about this
change. I think it would be better if you put that information in the
STATUS file, because anyone evaluating the backport proposal should be
aware of the reasons for this change (of course they should be reading
dev@ too) and also I think it will be easier to find this information
in the future if you attach it directly to the backport proposal, or
alternatively to the commit log messages. That was my point.
Regards,
- Julian
> BTW I think I have a solution for the replay problem at the cost of a few lb
> of ram.
Julian Foad wrote:
> Bert Huijben wrote:
>>> Subject: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
>>> + * r1715224, r1715232, r1715262
>>> + ra_serf: Fix setting Content-Type header in 3 outgoing xml requests
>>> + Justification:
>>> + We should properly implement our wire protocol.
>>> + Votes:
>>> + +1: rhuijben
>
>> These were found via a bug in httpd 2.4.17, where it doesn't handle
>> requests via http/2 with a body unless Content-Length or Content-Type is
>> set.
>
>> This should not affect normal Subversion usage, but it makes our http
>> usage a bit cleaner.
>
> It would be a good idea to copy this information into the STATUS file.
>
> - Julian
RE: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Posted by Bert Huijben <be...@qqmail.nl>.
There is currently no way how a user with released software can encounter this problem.
BTW I think I have a solution for the replay problem at the cost of a few lb of ram.
Bert
Sent from Outlook Mail for Windows 10 phone
From: Julian Foad
Sent: vrijdag 20 november 2015 12:04
To: Bert Huijben
Cc: dev
Subject: Re: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Bert Huijben wrote:
>> Subject: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
>
>> + * r1715224, r1715232, r1715262
>> + ra_serf: Fix setting Content-Type header in 3 outgoing xml requests
>> + Justification:
>> + We should properly implement our wire protocol.
>> + Votes:
>> + +1: rhuijben
>
> These were found via a bug in httpd 2.4.17, where it doesn't handle requests via http/2 with a body unless Content-Length or Content-Type is set.
>
> This should not affect normal Subversion usage, but it makes our http usage a bit cleaner.
It would be a good idea to copy this information into the STATUS file.
- Julian
Re: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Posted by Julian Foad <ju...@gmail.com>.
Bert Huijben wrote:
>> Subject: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
>
>> + * r1715224, r1715232, r1715262
>> + ra_serf: Fix setting Content-Type header in 3 outgoing xml requests
>> + Justification:
>> + We should properly implement our wire protocol.
>> + Votes:
>> + +1: rhuijben
>
> These were found via a bug in httpd 2.4.17, where it doesn't handle requests via http/2 with a body unless Content-Length or Content-Type is set.
>
> This should not affect normal Subversion usage, but it makes our http usage a bit cleaner.
It would be a good idea to copy this information into the STATUS file.
- Julian
RE: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: rhuijben@apache.org [mailto:rhuijben@apache.org]
> Sent: donderdag 19 november 2015 21:52
> To: commits@subversion.apache.org
> Subject: svn commit: r1715269 - /subversion/branches/1.9.x/STATUS
>
> + * r1715224, r1715232, r1715262
> + ra_serf: Fix setting Content-Type header in 3 outgoing xml requests
> + Justification:
> + We should properly implement our wire protocol.
> + Votes:
> + +1: rhuijben
These were found via a bug in httpd 2.4.17, where it doesn't handle requests via http/2 with a body unless Content-Length or Content-Type is set.
This should not affect normal Subversion usage, but it makes our http usage a bit cleaner.
Bert