You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/04 06:44:35 UTC

[GitHub] [shardingsphere-elasticjob-lite] taojintianxia opened a new pull request #933: Check style fix

taojintianxia opened a new pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933


   Changes proposed in this pull request:
   - remove useless checkstyle issue
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933#discussion_r449752334



##########
File path: elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/dto/request/FindJobExecutionEventsRequest.java
##########
@@ -55,8 +55,8 @@
      * @param pageSize page size
      */
     public FindJobExecutionEventsRequest(final Integer pageSize, final Integer pageNumber) {
-        this.pageSize = pageSize;
-        this.pageNumber = pageNumber;
+        setPageSize(pageSize);

Review comment:
       Please just use this.xxx to assign regular fields




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] taojintianxia commented on a change in pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933#discussion_r449768992



##########
File path: examples/elastic-job-example-lite-java/src/main/java/org/apache/shardingsphere/elasticjob/lite/example/JavaMain.java
##########
@@ -55,7 +55,7 @@
     private static final String EVENT_RDB_STORAGE_USERNAME = "sa";
     
     private static final String EVENT_RDB_STORAGE_PASSWORD = "";
-    
+

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] taojintianxia commented on a change in pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933#discussion_r449756670



##########
File path: elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/dto/request/FindJobExecutionEventsRequest.java
##########
@@ -55,8 +55,8 @@
      * @param pageSize page size
      */
     public FindJobExecutionEventsRequest(final Integer pageSize, final Integer pageNumber) {
-        this.pageSize = pageSize;
-        this.pageNumber = pageNumber;
+        setPageSize(pageSize);

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] taojintianxia commented on a change in pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933#discussion_r449769005



##########
File path: elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/dto/request/FindJobStatusTraceEventsRequest.java
##########
@@ -52,15 +52,11 @@
     private Date end;
     
     public FindJobStatusTraceEventsRequest(final Integer pageSize, final Integer pageNumber) {
-        this.pageSize = pageSize;
-        this.pageNumber = pageNumber;
+        super(pageSize, pageNumber, null, null);
     }
-    
+

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] terrymanu merged pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #933: Check style fix

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #933:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/933#discussion_r449767583



##########
File path: examples/elastic-job-example-lite-java/src/main/java/org/apache/shardingsphere/elasticjob/lite/example/JavaMain.java
##########
@@ -55,7 +55,7 @@
     private static final String EVENT_RDB_STORAGE_USERNAME = "sa";
     
     private static final String EVENT_RDB_STORAGE_PASSWORD = "";
-    
+

Review comment:
       Please do not change original indent

##########
File path: elastic-job-lite-console/src/main/java/org/apache/shardingsphere/elasticjob/lite/console/dto/request/FindJobStatusTraceEventsRequest.java
##########
@@ -52,15 +52,11 @@
     private Date end;
     
     public FindJobStatusTraceEventsRequest(final Integer pageSize, final Integer pageNumber) {
-        this.pageSize = pageSize;
-        this.pageNumber = pageNumber;
+        super(pageSize, pageNumber, null, null);
     }
-    
+

Review comment:
       Please do not change original indent




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org