[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

[GitBox <gi...@apache.org>]

neoremind commented on a change in pull request #91:
URL: https://github.com/apache/lucene/pull/91#discussion_r627930760



##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java
##########
@@ -35,63 +37,60 @@
 
   MutablePointsReaderUtils() {}
 
-  /** Sort the given {@link MutablePointValues} based on its packed value then doc ID. */
+  /**
+   * Sort the given {@link MutablePointValues} based on its packed value, note that doc ID is not
+   * taken into sorting algorithm, since if they are already in ascending order, stable sort is able
+   * to maintain the ordering of doc ID.
+   */

Review comment:
       @jpountz any further suggestions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org