You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/10 20:39:32 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
barry-jin opened a new pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512
## Description ##
Disable ssl verfication in link check & fix links redirect to 404
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897061769
Jenkins CI successfully triggered : [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-896841584
Jenkins CI successfully triggered : [centos-gpu, unix-cpu, miscellaneous, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897765996
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-896301744
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-gpu, unix-gpu, miscellaneous, centos-gpu, unix-cpu, sanity, website, windows-cpu, clang, centos-cpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on a change in pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on a change in pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#discussion_r687762342
##########
File path: docs/python_docs/python/scripts/conf.py
##########
@@ -69,6 +69,9 @@
autosummary_generate = True
numpydoc_show_class_members = False
+# Disable SSL verification in link check.
+tls_verify = False
Review comment:
Does tls_verify is a GitLab Runner configuration? Shouldn't the tls_verify be disabled by default? Following the [doc](https://docs.gitlab.com/runner/configuration/advanced-configuration.html)
> tls_verify Enable or disable TLS verification of connections to Docker daemon. Disabled by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on a change in pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
barry-jin commented on a change in pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#discussion_r687880038
##########
File path: docs/python_docs/python/scripts/conf.py
##########
@@ -69,6 +69,9 @@
autosummary_generate = True
numpydoc_show_class_members = False
+# Disable SSL verification in link check.
+tls_verify = False
Review comment:
No, it's a configuration in sphinx to disable verifying the server certifications.
ref: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-tls_verify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897362444
@mxnet-bot run ci [centos-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897926911
@TristonC @szha Could you help review this PR. It should unblock centOS and website build tests in master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897061715
@mxnet-bot run ci [centos-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897362482
Jenkins CI successfully triggered : [unix-gpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20512: [DOC] Disable ssl verfication in link check & fix links redirect to 404
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-896841522
@mxnet-bot run ci [centos-cpu, centos-gpu, miscellaneous, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20512: [CI] Fix centos CI & website build
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20512:
URL: https://github.com/apache/incubator-mxnet/pull/20512#issuecomment-897765950
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org