You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2024/01/29 19:38:59 UTC
[PR] chore(CI): get docs building on ALL branches. [superset]
rusackas opened a new pull request, #26854:
URL: https://github.com/apache/superset/pull/26854
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR does a few things:
* Splits the github action for docs in half
* One now only runs on pushes to master... it builds and deploys docs after checking for secrets
* One now only runs on PRs, and doesn't need secrets. It does typechecking (new step) and builds docs, and should run even on forks (e.g. dependabot bumps)
* Fixes a couple of typescript checks that were noticed by the typechecking script.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(CI): get docs building on ALL branches. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #26854:
URL: https://github.com/apache/superset/pull/26854#discussion_r1470140408
##########
.github/workflows/superset-docs-verify.yml:
##########
@@ -1,15 +1,11 @@
-name: Docs
+name: Docs Deployment
Review Comment:
Oops! Names were right in the file, but the filenames themselves were wrong. Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(CI): get docs building on ALL branches. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #26854:
URL: https://github.com/apache/superset/pull/26854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(CI): get docs building on ALL branches. [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #26854:
URL: https://github.com/apache/superset/pull/26854#discussion_r1470134217
##########
.github/workflows/superset-docs-deploy.yml:
##########
@@ -0,0 +1,29 @@
+name: Docs Testing
+
+on:
+ pull_request:
+ paths:
+ - "docs/**"
+ types: [synchronize, opened, reopened, ready_for_review]
+jobs:
+ build-deploy:
+ name: Build & Deploy
+ runs-on: ubuntu-20.04
+ defaults:
+ run:
+ working-directory: docs
+ steps:
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: yarn install
Review Comment:
for these yarn commands, shouldn't there be a `cd docs` before?
##########
.github/workflows/superset-docs-verify.yml:
##########
@@ -1,15 +1,11 @@
-name: Docs
+name: Docs Deployment
Review Comment:
I think the filenames are reversed from what they should be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(CI): get docs building on ALL branches. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #26854:
URL: https://github.com/apache/superset/pull/26854#discussion_r1470138197
##########
.github/workflows/superset-docs-deploy.yml:
##########
@@ -0,0 +1,29 @@
+name: Docs Testing
+
+on:
+ pull_request:
+ paths:
+ - "docs/**"
+ types: [synchronize, opened, reopened, ready_for_review]
+jobs:
+ build-deploy:
+ name: Build & Deploy
+ runs-on: ubuntu-20.04
+ defaults:
+ run:
+ working-directory: docs
+ steps:
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: recursive
+ - name: yarn install
Review Comment:
I believe the `working-directory` parameter does that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org