You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by Konstantin Boudnik <co...@apache.org> on 2016/05/04 02:19:11 UTC
The discrepancies of '-' and '_'
I believe I even know the reason for it, but still it is dazzles me to a
stupor each time I deal with it. Namely, in the build, we use '-' as they are
legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
However, in the deployment we use '_' everywhere (because of some oddities
with hiera and whatnot). That said, it is quite confusing to have two
different notations here and there and keep them in mind ;(
Shall we be doing something about it? Or no one else besides me is getting
pissed with it?
Cos
Re: The discrepancies of '-' and '_'
Posted by Konstantin Boudnik <co...@apache.org>.
On Mon, May 09, 2016 at 10:09PM, Olaf Flebbe wrote:
> Hi,
>
> Changing names will break bigtop release upgrade procedure much more severely than the proposed patch
> BIGTOP-2414 for instance. Please don't .
Fair enough.
> And BTW anyone interested in tachyon: Please chime into BIGTOP-2414.
I don't see how it is relevant to the discussion at hands, but I will leave to
people who really interested in Tachyon.
Cos
> > Am 09.05.2016 um 21:09 schrieb Konstantin Boudnik <co...@apache.org>:
> >
> > Thanks for refreshing the memories, Olaf! But I guess the point I was trying t
> > make is that perhaps we should make the component names using the same
> > separators in the puppet and the build? Because we can not change recipes,
> > then it would make sense to make the changes in the component names?
> >
> > Unless I am the only one who doesn't like it or we don't want to make all
> > these changes in the build/CI/elsewhere...
> >
> > Cos
> >
> > On Mon, May 09, 2016 at 08:03PM, Olaf Flebbe wrote:
> >> Hi,
> >>
> >> A oversimplification: puppet class identifiers must not contain dashes '-' . In fact there are fine points regarding '-' (https://projects.puppetlabs.com/projects/puppet/wiki/Allowed_Characters_in_Identifier_Names), which should be worked around by not using '-' for puppet class identifiers.
> >>
> >> So we have to replace '-' with '_' at deployment time for puppet class names modelled after the package names. That's simple.
> >>
> >> Olaf
> >>
> >>
> >>> Am 09.05.2016 um 06:30 schrieb Roman Shaposhnik <ro...@shaposhnik.org>:
> >>>
> >>> On Tue, May 3, 2016 at 5:19 PM, Konstantin Boudnik <co...@apache.org> wrote:
> >>>> I believe I even know the reason for it, but still it is dazzles me to a
> >>>> stupor each time I deal with it. Namely, in the build, we use '-' as they are
> >>>> legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
> >>>>
> >>>> However, in the deployment we use '_' everywhere (because of some oddities
> >>>> with hiera and whatnot). That said, it is quite confusing to have two
> >>>> different notations here and there and keep them in mind ;(
> >>>>
> >>>> Shall we be doing something about it? Or no one else besides me is getting
> >>>> pissed with it?
> >>>
> >>> FWIW: I kind of got used to it I guess. Still, if anybody has a plan to make it
> >>> less confusing I can pitch in with code changes.
> >>>
> >>> Thanks,
> >>> Roman.
> >>
> >
> >
>
Re: The discrepancies of '-' and '_'
Posted by Olaf Flebbe <of...@oflebbe.de>.
Hi,
Changing names will break bigtop release upgrade procedure much more severely than the proposed patch
BIGTOP-2414 for instance. Please don't .
And BTW anyone interested in tachyon: Please chime into BIGTOP-2414.
Olaf
> Am 09.05.2016 um 21:09 schrieb Konstantin Boudnik <co...@apache.org>:
>
> Thanks for refreshing the memories, Olaf! But I guess the point I was trying t
> make is that perhaps we should make the component names using the same
> separators in the puppet and the build? Because we can not change recipes,
> then it would make sense to make the changes in the component names?
>
> Unless I am the only one who doesn't like it or we don't want to make all
> these changes in the build/CI/elsewhere...
>
> Cos
>
> On Mon, May 09, 2016 at 08:03PM, Olaf Flebbe wrote:
>> Hi,
>>
>> A oversimplification: puppet class identifiers must not contain dashes '-' . In fact there are fine points regarding '-' (https://projects.puppetlabs.com/projects/puppet/wiki/Allowed_Characters_in_Identifier_Names), which should be worked around by not using '-' for puppet class identifiers.
>>
>> So we have to replace '-' with '_' at deployment time for puppet class names modelled after the package names. That's simple.
>>
>> Olaf
>>
>>
>>> Am 09.05.2016 um 06:30 schrieb Roman Shaposhnik <ro...@shaposhnik.org>:
>>>
>>> On Tue, May 3, 2016 at 5:19 PM, Konstantin Boudnik <co...@apache.org> wrote:
>>>> I believe I even know the reason for it, but still it is dazzles me to a
>>>> stupor each time I deal with it. Namely, in the build, we use '-' as they are
>>>> legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
>>>>
>>>> However, in the deployment we use '_' everywhere (because of some oddities
>>>> with hiera and whatnot). That said, it is quite confusing to have two
>>>> different notations here and there and keep them in mind ;(
>>>>
>>>> Shall we be doing something about it? Or no one else besides me is getting
>>>> pissed with it?
>>>
>>> FWIW: I kind of got used to it I guess. Still, if anybody has a plan to make it
>>> less confusing I can pitch in with code changes.
>>>
>>> Thanks,
>>> Roman.
>>
>
>
Re: The discrepancies of '-' and '_'
Posted by Konstantin Boudnik <co...@apache.org>.
Thanks for refreshing the memories, Olaf! But I guess the point I was trying t
make is that perhaps we should make the component names using the same
separators in the puppet and the build? Because we can not change recipes,
then it would make sense to make the changes in the component names?
Unless I am the only one who doesn't like it or we don't want to make all
these changes in the build/CI/elsewhere...
Cos
On Mon, May 09, 2016 at 08:03PM, Olaf Flebbe wrote:
> Hi,
>
> A oversimplification: puppet class identifiers must not contain dashes '-' . In fact there are fine points regarding '-' (https://projects.puppetlabs.com/projects/puppet/wiki/Allowed_Characters_in_Identifier_Names), which should be worked around by not using '-' for puppet class identifiers.
>
> So we have to replace '-' with '_' at deployment time for puppet class names modelled after the package names. That's simple.
>
> Olaf
>
>
> > Am 09.05.2016 um 06:30 schrieb Roman Shaposhnik <ro...@shaposhnik.org>:
> >
> > On Tue, May 3, 2016 at 5:19 PM, Konstantin Boudnik <co...@apache.org> wrote:
> >> I believe I even know the reason for it, but still it is dazzles me to a
> >> stupor each time I deal with it. Namely, in the build, we use '-' as they are
> >> legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
> >>
> >> However, in the deployment we use '_' everywhere (because of some oddities
> >> with hiera and whatnot). That said, it is quite confusing to have two
> >> different notations here and there and keep them in mind ;(
> >>
> >> Shall we be doing something about it? Or no one else besides me is getting
> >> pissed with it?
> >
> > FWIW: I kind of got used to it I guess. Still, if anybody has a plan to make it
> > less confusing I can pitch in with code changes.
> >
> > Thanks,
> > Roman.
>
Re: The discrepancies of '-' and '_'
Posted by Olaf Flebbe <of...@oflebbe.de>.
Hi,
A oversimplification: puppet class identifiers must not contain dashes '-' . In fact there are fine points regarding '-' (https://projects.puppetlabs.com/projects/puppet/wiki/Allowed_Characters_in_Identifier_Names), which should be worked around by not using '-' for puppet class identifiers.
So we have to replace '-' with '_' at deployment time for puppet class names modelled after the package names. That's simple.
Olaf
> Am 09.05.2016 um 06:30 schrieb Roman Shaposhnik <ro...@shaposhnik.org>:
>
> On Tue, May 3, 2016 at 5:19 PM, Konstantin Boudnik <co...@apache.org> wrote:
>> I believe I even know the reason for it, but still it is dazzles me to a
>> stupor each time I deal with it. Namely, in the build, we use '-' as they are
>> legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
>>
>> However, in the deployment we use '_' everywhere (because of some oddities
>> with hiera and whatnot). That said, it is quite confusing to have two
>> different notations here and there and keep them in mind ;(
>>
>> Shall we be doing something about it? Or no one else besides me is getting
>> pissed with it?
>
> FWIW: I kind of got used to it I guess. Still, if anybody has a plan to make it
> less confusing I can pitch in with code changes.
>
> Thanks,
> Roman.
Re: The discrepancies of '-' and '_'
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Tue, May 3, 2016 at 5:19 PM, Konstantin Boudnik <co...@apache.org> wrote:
> I believe I even know the reason for it, but still it is dazzles me to a
> stupor each time I deal with it. Namely, in the build, we use '-' as they are
> legit for identifiers. Case in point, ignite-hadoop, bigtop-groovy, etc.
>
> However, in the deployment we use '_' everywhere (because of some oddities
> with hiera and whatnot). That said, it is quite confusing to have two
> different notations here and there and keep them in mind ;(
>
> Shall we be doing something about it? Or no one else besides me is getting
> pissed with it?
FWIW: I kind of got used to it I guess. Still, if anybody has a plan to make it
less confusing I can pitch in with code changes.
Thanks,
Roman.