You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/06/28 11:12:32 UTC

Review Request 12156: CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12156/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-3189


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.

https://issues.apache.org/jira/browse/CLOUDSTACK-3189


Diffs
-----

  server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 

Diff: https://reviews.apache.org/r/12156/diff/


Testing
-------

Tests:

1. Create a volume from a user account.
2. Verify the increment in primaryStorageTotal count using listAccount API.
3. Delete volume.
4. Verify the decrement in primaryStorageTotal count.


Thanks,

Sanjay Tripathi


Re: Review Request 12156: CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12156/#review22623
-----------------------------------------------------------


Commit af4eb22a6539b9c25f6b9df2aa110bf099283cbb in branch refs/heads/4.2 from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=af4eb22 ]

CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
When a volume is created the resource usage for it gets incremented. If it is deleted without being
attached to a volume, the decrement doesn't take place. Fixed the delete volume code to decrement
resource usage for a volume in allocated state too.


- ASF Subversion and Git Services


On June 28, 2013, 9:12 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12156/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 9:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3189
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3189
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 
> 
> Diff: https://reviews.apache.org/r/12156/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume from a user account.
> 2. Verify the increment in primaryStorageTotal count using listAccount API.
> 3. Delete volume.
> 4. Verify the decrement in primaryStorageTotal count.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12156: CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12156/#review22616
-----------------------------------------------------------


Commit 301c91c099957b77dd1127484446f9fe69b53e39 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=301c91c ]

CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
When a volume is created the resource usage for it gets incremented. If it is deleted without being
attached to a volume, the decrement doesn't take place. Fixed the delete volume code to decrement
resource usage for a volume in allocated state too.


- ASF Subversion and Git Services


On June 28, 2013, 9:12 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12156/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 9:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3189
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3189
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 
> 
> Diff: https://reviews.apache.org/r/12156/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume from a user account.
> 2. Verify the increment in primaryStorageTotal count using listAccount API.
> 3. Delete volume.
> 4. Verify the decrement in primaryStorageTotal count.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request 12156: CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12156/#review22618
-----------------------------------------------------------


Commit 737a9c397755f979bd42a1504bd0b298b4f74825 in branch refs/heads/master-6-17-stable from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=737a9c3 ]

CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
When a volume is created the resource usage for it gets incremented. If it is deleted without being
attached to a volume, the decrement doesn't take place. Fixed the delete volume code to decrement
resource usage for a volume in allocated state too.


- ASF Subversion and Git Services


On June 28, 2013, 9:12 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12156/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 9:12 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3189
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3189: Primary storage usage is not getting decremented after deleting the DATA volumes.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3189
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 4297efb 
> 
> Diff: https://reviews.apache.org/r/12156/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> 
> 1. Create a volume from a user account.
> 2. Verify the increment in primaryStorageTotal count using listAccount API.
> 3. Delete volume.
> 4. Verify the decrement in primaryStorageTotal count.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>