You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/29 15:57:28 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #12830: Unify sql-case-id name pattern in test cases

terrymanu opened a new issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830


   Currently, `sql-case-ids` are specified in both camel case and snake case.
   
   It is better to use snake-case. Please unify the sql-case-id in xml test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-930320092


   @ThanoshanMV Welcome, I just assign it to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] ThanoshanMV edited a comment on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-933317629


   Distributed SQL case ids are in spinal-case. Should we need to change them into snake-case, or spinal-case is the recommended one?
   
   Do we need to consider unifying sql-case-ids cases in unsupported SQLs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] ThanoshanMV commented on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-930313931


   I'll try to do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] ThanoshanMV commented on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-930313931


   I'll try to do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] ThanoshanMV commented on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-933317629


   Distributed SQL case ids are in spinal-case. Should we need to change them into snake-case or spinal-case is the recommended one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #12830: Unify sql-case-id name pattern in SQL parser test cases

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #12830:
URL: https://github.com/apache/shardingsphere/issues/12830#issuecomment-930320092


   @ThanoshanMV Welcome, I just assign it to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org