[GitHub] [spark] juliuszsompolski commented on a change in pull request #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9

[GitBox <gi...@apache.org>]

juliuszsompolski commented on a change in pull request #25721: [WIP][SPARK-29018][SQL] Implement Spark Thrift Server with it's own code base on PROTOCOL_VERSION_V9
URL: https://github.com/apache/spark/pull/25721#discussion_r336992948
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1730,7 +1730,58 @@
           </exclusion>
         </exclusions>
       </dependency>
-
+      <dependency>
+        <groupId>${hive.group}</groupId>
+        <artifactId>hive-service</artifactId>
 
 Review comment:
   I thought that this is cutting away dependency on Hive?
   
   Also, does it need to be defined in root pom.xml? (genuinely asking: I know little about maven)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org