You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/05 15:28:33 UTC

[GitHub] [arrow] lidavidm commented on pull request #13509: ARROW-16700: [C++][R][Datasets] aggregates on partitioning columns

lidavidm commented on PR #13509:
URL: https://github.com/apache/arrow/pull/13509#issuecomment-1175194160

   My bad, I was looking at the hash aggregate tests! 
   
   I suppose the 'right' way to test it is to construct an ExecPlan and feed the data through. There are some tests in plan_test.cc but it doesn't have much coverage of the kernels themselves. We may need some parameterization/a helper to test "both ways" of calling aggregates in much the same way hash_aggregate_test.cc does.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org