[jira] [Commented] (ARROW-3979) [Gandiva] fix all valgrind reported errors

["Antoine Pitrou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-3979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722871#comment-16722871 ] 

Antoine Pitrou commented on ARROW-3979:
---------------------------------------

If you need guidance or help on this don't hesitate to ask.
 One issue I've noticed is with the re2 library. I've added this to the {{valgrind.supp}} file:
{code:java}
# Various issues in the re2 regexp constructor (used by Gandiva)
{
    <re2>:Conditional jump or move depends on uninitialised value(s)
    Memcheck:Cond
    ...
    fun:_ZN3re23RE2C1E*
}
{
    <re2>:Use of uninitialised value of size 8
    Memcheck:Value8
    ...
    fun:_ZN3re23RE2C1E*
}
{code}
Another issue is the following macro:
{code:java}
#define REGISTER_EXPORTED_FUNCS(classname) \
  static bool _registered_##classname = ExportedFuncsRegistry::Register(new classname)
{code}
It allocates an object that's never deleted. One solution is to use a {{unique_ptr}} or {{shared_ptr}} instead. If not possible, then it should be silenced in the suppressions file.

> [Gandiva] fix all valgrind reported errors
> ------------------------------------------
>
>                 Key: ARROW-3979
>                 URL: https://issues.apache.org/jira/browse/ARROW-3979
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Gandiva
>            Reporter: Pindikura Ravindra
>            Assignee: shyam narayan singh
>            Priority: Major
>
> Travis reports lots of valgrind errors when running gandiva tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)