[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1653: suppport bitwise and as an example

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1653:
URL: https://github.com/apache/arrow-datafusion/pull/1653#discussion_r791142820



##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -334,6 +334,141 @@ fn modulus_decimal(left: &DecimalArray, right: &DecimalArray) -> Result<DecimalA
     Ok(decimal_builder.finish())
 }
 
+fn bitwise_and(left: ArrayRef, right: ArrayRef) -> Result<ArrayRef> {

Review comment:
       yeah, these kernels would really be nicer if they were in arrow (where we can probably leverage all the bitwise hackery). It is reasonable to start in datafusion however, and then move them to arrow




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org