You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/22 12:53:11 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1300: MINIFICPP-1675 Use regex.h instead of std::regex when using libstdc++

szaszm commented on code in PR #1300:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1300#discussion_r856199399


##########
extensions/standard-processors/tests/unit/ExtractTextTests.cpp:
##########
@@ -180,3 +181,36 @@ TEST_CASE("Test usage of ExtractText in regex mode", "[extracttextRegexTest]") {
 
   LogTestController::getInstance().reset();
 }
+
+#ifndef NO_MORE_REGFREEE

Review Comment:
   Is this `#ifndef` required? It should work in either case if I understand correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org